From: Ed Bartosh <ed.bartosh@linux.intel.com>
To: Elliot Smith <elliot.smith@intel.com>
Cc: toaster@yoctoproject.org
Subject: Re: [review-request][PATCH 00/23][V2] Convert projects and builds pages to ToasterTable
Date: Fri, 15 Jan 2016 13:07:48 +0200 [thread overview]
Message-ID: <20160115110748.GA22249@linux.intel.com> (raw)
In-Reply-To: <1452858230-31457-1-git-send-email-elliot.smith@intel.com>
Hi,
Patchset looks ok to me. Submitted upstream.
Regards,
Ed
On Fri, Jan 15, 2016 at 11:43:27AM +0000, Elliot Smith wrote:
> V2:
>
> Minor code formatting and fixes in line with code review by Ed Bartosh.
>
> V1:
>
> Many of the tables displayed by Toaster are backed by ToasterTable, but some
> of the key ones (like "projects", "all builds", and "project builds") aren't.
>
> This makes it difficult to keep styling consistent between tables, as some
> are styled by making changes to ToasterTable, while others are styled
> by modifying Django templates.
>
> Improve the consistency and maintainability of these tables by converting
> them to use ToasterTable.
>
> Note that this patchset also reworks the ToasterTable API so that we can easily
> support different column filter types.
>
> To test:
>
> 1. Open the "projects", "all builds" and "project builds" pages in Toaster.
> 2. Check that the column filtering and sorting works correctly, and projects/builds
> display correctly.
>
> Changes since ea666f6 (toaster-next) are in
> git://git.yoctoproject.org/poky-contrib, elliot/toaster/tables-8738
> http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/tables-8738
>
> Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=8738
>
> Elliot Smith (23):
> toaster: toastergui: use ToasterTable for projects page
> toaster: move image file suffix list to model
> toaster: check inferred file suffixes against list of known types
> toaster: toastergui: switch projects/ view to ToasterTable
> toaster: toastergui: use event delegates for hover help elements
> toaster: toastergui: convert all builds page to ToasterTable
> toaster: toastergui: refactor ToasterTable filtering
> toaster: toastergui: switch off filter highlights when inactive
> toaster: toastergui: show recent builds on all builds page
> toaster: toastergui: implement date range filters for builds
> toaster: toastergui: implement "today" and "yesterday" filters
> toaster: toastergui: convert project builds page to ToasterTable
> toaster: toastergui: don't hide all elements with .col class
> toaster: toastergui: ensure filter_value updates
> toaster: toastergui: streamline construction of filter objects
> toaster: toastergui: serialise decimals correctly
> toaster: toastergui: set default visible and hideable columns
> toaster: toastergui: mute label for filter actions with no records
> toaster: toastergui: make "Apply" button state depend on filter range
> toaster: toastergui: fix error and warning counts for builds
> toaster: toastergui: remove unused views and template code
> toaster: tests: fix Django tests for new ToasterTable pages
> toaster: toastergui: code formatting and clean-up
>
> .../contrib/django-aggregate-if-master/.gitignore | 10 -
> .../contrib/django-aggregate-if-master/.travis.yml | 50 --
> .../contrib/django-aggregate-if-master/LICENSE | 21 -
> .../contrib/django-aggregate-if-master/README.rst | 156 ----
> .../django-aggregate-if-master/aggregate_if.py | 164 ----
> .../contrib/django-aggregate-if-master/runtests.py | 48 --
> .../contrib/django-aggregate-if-master/setup.py | 33 -
> .../contrib/django-aggregate-if-master/tox.ini | 198 -----
> bitbake/lib/toaster/orm/models.py | 103 ++-
> .../lib/toaster/toastergui/static/js/libtoaster.js | 6 +-
> .../toaster/toastergui/static/js/projecttopbar.js | 9 +
> bitbake/lib/toaster/toastergui/static/js/table.js | 325 ++++++--
> bitbake/lib/toaster/toastergui/tablefilter.py | 292 +++++++
> bitbake/lib/toaster/toastergui/tables.py | 858 +++++++++++++++++++--
> .../toastergui/templates/baseprojectpage.html | 1 +
> .../toastergui/templates/builds-toastertable.html | 48 ++
> .../lib/toaster/toastergui/templates/builds.html | 125 ---
> .../toaster/toastergui/templates/mrb_section.html | 4 +-
> .../templates/projectbuilds-toastertable.html | 56 ++
> .../templates/projects-toastertable.html | 36 +
> .../lib/toaster/toastergui/templates/projects.html | 92 ---
> .../toastergui/templates/toastertable-filter.html | 4 +-
> .../toaster/toastergui/templates/toastertable.html | 7 +-
> bitbake/lib/toaster/toastergui/tests.py | 265 +++++--
> bitbake/lib/toaster/toastergui/urls.py | 14 +-
> bitbake/lib/toaster/toastergui/views.py | 491 +-----------
> bitbake/lib/toaster/toastergui/widgets.py | 112 +--
> bitbake/lib/toaster/toastermain/settings.py | 9 -
> 28 files changed, 1898 insertions(+), 1639 deletions(-)
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.gitignore
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/.travis.yml
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/LICENSE
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/README.rst
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/aggregate_if.py
> delete mode 100755 bitbake/lib/toaster/contrib/django-aggregate-if-master/runtests.py
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/setup.py
> delete mode 100644 bitbake/lib/toaster/contrib/django-aggregate-if-master/tox.ini
> create mode 100644 bitbake/lib/toaster/toastergui/tablefilter.py
> create mode 100644 bitbake/lib/toaster/toastergui/templates/builds-toastertable.html
> delete mode 100644 bitbake/lib/toaster/toastergui/templates/builds.html
> create mode 100644 bitbake/lib/toaster/toastergui/templates/projectbuilds-toastertable.html
> create mode 100644 bitbake/lib/toaster/toastergui/templates/projects-toastertable.html
> delete mode 100644 bitbake/lib/toaster/toastergui/templates/projects.html
>
> --
> Elliot Smith
> Software Engineer
> Intel OTC
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> --
> _______________________________________________
> toaster mailing list
> toaster@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/toaster
--
--
Regards,
Ed
next prev parent reply other threads:[~2016-01-15 13:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 11:43 [review-request][PATCH 00/23][V2] Convert projects and builds pages to ToasterTable Elliot Smith
2016-01-15 11:07 ` Ed Bartosh [this message]
2016-01-15 11:43 ` [review-request][PATCH 01/23] toaster: toastergui: use ToasterTable for projects page Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 02/23] toaster: move image file suffix list to model Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 03/23] toaster: check inferred file suffixes against list of known types Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 04/23] toaster: toastergui: switch projects/ view to ToasterTable Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 05/23] toaster: toastergui: use event delegates for hover help elements Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 06/23] toaster: toastergui: convert all builds page to ToasterTable Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 07/23] toaster: toastergui: refactor ToasterTable filtering Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 08/23] toaster: toastergui: switch off filter highlights when inactive Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 09/23] toaster: toastergui: show recent builds on all builds page Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 10/23] toaster: toastergui: implement date range filters for builds Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 11/23] toaster: toastergui: implement "today" and "yesterday" filters Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 12/23] toaster: toastergui: convert project builds page to ToasterTable Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 13/23] toaster: toastergui: don't hide all elements with .col class Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 14/23] toaster: toastergui: ensure filter_value updates Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 15/23] toaster: toastergui: streamline construction of filter objects Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 16/23] toaster: toastergui: serialise decimals correctly Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 17/23] toaster: toastergui: set default visible and hideable columns Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 18/23] toaster: toastergui: mute label for filter actions with no records Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 19/23] toaster: toastergui: make "Apply" button state depend on filter range Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 20/23] toaster: toastergui: fix error and warning counts for builds Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 21/23] toaster: toastergui: remove unused views and template code Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 22/23] toaster: tests: fix Django tests for new ToasterTable pages Elliot Smith
2016-01-15 11:43 ` [review-request][PATCH 23/23] toaster: toastergui: code formatting and clean-up Elliot Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160115110748.GA22249@linux.intel.com \
--to=ed.bartosh@linux.intel.com \
--cc=elliot.smith@intel.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.