All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Geoff Levand <geoff@infradead.org>
Cc: marc.zyngier@arm.com, Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	AKASHI Takahiro <takahiro.akashi@linaro.org>,
	James Morse <james.morse@arm.com>,
	linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org,
	christoffer.dall@linaro.org
Subject: Re: [PATCH 09/19] Revert "arm64: remove dead code"
Date: Fri, 15 Jan 2016 19:55:18 +0000	[thread overview]
Message-ID: <20160115195517.GP3262@leverpostej> (raw)
In-Reply-To: <81d9f2f035e6ae0e1a121f3eddeaef915d761e2d.1452884156.git.geoff@infradead.org>

Hi,

On Fri, Jan 15, 2016 at 07:18:37PM +0000, Geoff Levand wrote:
> This reverts commit b08d4640a3dca68670fc5af2fe9205b395a02388.
> 
> Add back the setup_mm_for_reboot() needed for kexec.

My pagetable rework series [1,2] adds cpu_install_idmap() [3], which
supersedes setup_mm_for_reboot, and differs only in name.

I intend to rebase once v4.5-rc1 comes out. Unless there are substantial
changes or new comments, I expect that to be on a stable branche shortly
thereafter. When that happens, it should be possible to drop this patch.

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/397095.html
[2] https://git.kernel.org/cgit/linux/kernel/git/mark/linux.git/log/?h=arm64/pagetable-rework
[3] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/397101.html

> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  arch/arm64/include/asm/mmu.h |  1 +
>  arch/arm64/mm/mmu.c          | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h
> index 990124a..6326d11 100644
> --- a/arch/arm64/include/asm/mmu.h
> +++ b/arch/arm64/include/asm/mmu.h
> @@ -29,6 +29,7 @@ typedef struct {
>  #define ASID(mm)	((mm)->context.id.counter & 0xffff)
>  
>  extern void paging_init(void);
> +extern void setup_mm_for_reboot(void);
>  extern void __iomem *early_io_map(phys_addr_t phys, unsigned long virt);
>  extern void init_mem_pgprot(void);
>  extern void create_pgd_mapping(struct mm_struct *mm, phys_addr_t phys,
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 873e363..afcf1ee 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -466,6 +466,17 @@ void __init paging_init(void)
>  }
>  
>  /*
> + * Enable the identity mapping to allow the MMU disabling.
> + */
> +void setup_mm_for_reboot(void)
> +{
> +	cpu_set_reserved_ttbr0();
> +	flush_tlb_all();
> +	cpu_set_idmap_tcr_t0sz();
> +	cpu_switch_mm(idmap_pg_dir, &init_mm);
> +}
> +
> +/*
>   * Check whether a kernel address is valid (derived from arch/x86/).
>   */
>  int kern_addr_valid(unsigned long addr)
> -- 
> 2.5.0
> 
> 

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/19] Revert "arm64: remove dead code"
Date: Fri, 15 Jan 2016 19:55:18 +0000	[thread overview]
Message-ID: <20160115195517.GP3262@leverpostej> (raw)
In-Reply-To: <81d9f2f035e6ae0e1a121f3eddeaef915d761e2d.1452884156.git.geoff@infradead.org>

Hi,

On Fri, Jan 15, 2016 at 07:18:37PM +0000, Geoff Levand wrote:
> This reverts commit b08d4640a3dca68670fc5af2fe9205b395a02388.
> 
> Add back the setup_mm_for_reboot() needed for kexec.

My pagetable rework series [1,2] adds cpu_install_idmap() [3], which
supersedes setup_mm_for_reboot, and differs only in name.

I intend to rebase once v4.5-rc1 comes out. Unless there are substantial
changes or new comments, I expect that to be on a stable branche shortly
thereafter. When that happens, it should be possible to drop this patch.

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/397095.html
[2] https://git.kernel.org/cgit/linux/kernel/git/mark/linux.git/log/?h=arm64/pagetable-rework
[3] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/397101.html

> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  arch/arm64/include/asm/mmu.h |  1 +
>  arch/arm64/mm/mmu.c          | 11 +++++++++++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h
> index 990124a..6326d11 100644
> --- a/arch/arm64/include/asm/mmu.h
> +++ b/arch/arm64/include/asm/mmu.h
> @@ -29,6 +29,7 @@ typedef struct {
>  #define ASID(mm)	((mm)->context.id.counter & 0xffff)
>  
>  extern void paging_init(void);
> +extern void setup_mm_for_reboot(void);
>  extern void __iomem *early_io_map(phys_addr_t phys, unsigned long virt);
>  extern void init_mem_pgprot(void);
>  extern void create_pgd_mapping(struct mm_struct *mm, phys_addr_t phys,
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index 873e363..afcf1ee 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -466,6 +466,17 @@ void __init paging_init(void)
>  }
>  
>  /*
> + * Enable the identity mapping to allow the MMU disabling.
> + */
> +void setup_mm_for_reboot(void)
> +{
> +	cpu_set_reserved_ttbr0();
> +	flush_tlb_all();
> +	cpu_set_idmap_tcr_t0sz();
> +	cpu_switch_mm(idmap_pg_dir, &init_mm);
> +}
> +
> +/*
>   * Check whether a kernel address is valid (derived from arch/x86/).
>   */
>  int kern_addr_valid(unsigned long addr)
> -- 
> 2.5.0
> 
> 

  reply	other threads:[~2016-01-15 19:55 UTC|newest]

Thread overview: 174+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 19:18 [PATCH 00/19] arm64 kexec kernel patches v13 Geoff Levand
2016-01-15 19:18 ` Geoff Levand
2016-01-15 19:18 ` [PATCH 04/19] arm64: Cleanup SCTLR flags Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 20:07   ` Mark Rutland
2016-01-15 20:07     ` Mark Rutland
2016-01-18 10:12     ` Marc Zyngier
2016-01-18 10:12       ` Marc Zyngier
2016-01-19 11:59       ` Dave Martin
2016-01-19 11:59         ` Dave Martin
2016-01-25 15:09   ` James Morse
2016-01-25 15:09     ` James Morse
2016-01-15 19:18 ` [PATCH 06/19] arm64: Add new hcall HVC_CALL_FUNC Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 07/19] arm64: Add back cpu_reset routines Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 05/19] arm64: Convert hcalls to use HVC immediate value Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 01/19] arm64: Fold proc-macros.S into assembler.h Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 08/19] Revert "arm64: mm: remove unused cpu_set_idmap_tcr_t0sz function" Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 09/19] Revert "arm64: remove dead code" Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:55   ` Mark Rutland [this message]
2016-01-15 19:55     ` Mark Rutland
2016-01-20 21:18     ` Geoff Levand
2016-01-20 21:18       ` Geoff Levand
2016-01-15 19:18 ` [PATCH 03/19] arm64: Add new asm macro copy_page Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-20 14:01   ` James Morse
2016-01-20 14:01     ` James Morse
2016-01-15 19:18 ` [PATCH 02/19] arm64: kernel: Include _AC definition in page.h Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-18 10:05   ` Mark Rutland
2016-01-18 10:05     ` Mark Rutland
2016-01-15 19:18 ` [PATCH 16/19] arm64: kdump: add kdump support Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-21 14:17   ` James Morse
2016-01-21 14:17     ` James Morse
2016-01-22  4:50     ` AKASHI Takahiro
2016-01-22  4:50       ` AKASHI Takahiro
2016-01-15 19:18 ` [PATCH 10/19] arm64: kvm: allows kvm cpu hotplug Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-26 17:42   ` James Morse
2016-01-26 17:42     ` James Morse
2016-01-27  7:37     ` AKASHI Takahiro
2016-01-27  7:37       ` AKASHI Takahiro
2016-01-15 19:18 ` [PATCH 17/19] arm64: kdump: enable kdump in the arm64 defconfig Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 18/19] arm64: kdump: update a kernel doc Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 20:16   ` Mark Rutland
2016-01-15 20:16     ` Mark Rutland
2016-01-18 10:26     ` AKASHI Takahiro
2016-01-18 10:26       ` AKASHI Takahiro
2016-01-18 11:29       ` Mark Rutland
2016-01-18 11:29         ` Mark Rutland
2016-01-19  5:31         ` AKASHI Takahiro
2016-01-19  5:31           ` AKASHI Takahiro
2016-01-19 12:10           ` Mark Rutland
2016-01-19 12:10             ` Mark Rutland
2016-01-20  4:34             ` AKASHI Takahiro
2016-01-20  4:34               ` AKASHI Takahiro
2016-01-19  1:43       ` Dave Young
2016-01-19  1:43         ` Dave Young
2016-01-19  1:50         ` Dave Young
2016-01-19  1:50           ` Dave Young
2016-01-19  5:35         ` AKASHI Takahiro
2016-01-19  5:35           ` AKASHI Takahiro
2016-01-19 12:28           ` Dave Young
2016-01-19 12:28             ` Dave Young
2016-01-19 12:51             ` Mark Rutland
2016-01-19 12:51               ` Mark Rutland
2016-01-19 13:45               ` Dave Young
2016-01-19 13:45                 ` Dave Young
2016-01-19 14:01                 ` Mark Rutland
2016-01-19 14:01                   ` Mark Rutland
2016-01-20  2:49                   ` Dave Young
2016-01-20  2:49                     ` Dave Young
2016-01-20  6:07                     ` AKASHI Takahiro
2016-01-20  6:07                       ` AKASHI Takahiro
2016-01-20  6:38                       ` Dave Young
2016-01-20  6:38                         ` Dave Young
2016-01-20  7:00                         ` Dave Young
2016-01-20  7:00                           ` Dave Young
2016-01-20  8:01                           ` AKASHI Takahiro
2016-01-20  8:01                             ` AKASHI Takahiro
2016-01-20  8:26                             ` Dave Young
2016-01-20  8:26                               ` Dave Young
2016-01-20 11:54                         ` Mark Rutland
2016-01-20 11:54                           ` Mark Rutland
2016-01-21  2:57                           ` Dave Young
2016-01-21  2:57                             ` Dave Young
2016-01-21  3:03                           ` Dave Young
2016-01-21  3:03                             ` Dave Young
2016-01-20 11:49                       ` Mark Rutland
2016-01-20 11:49                         ` Mark Rutland
2016-01-21  6:53                         ` AKASHI Takahiro
2016-01-21  6:53                           ` AKASHI Takahiro
2016-01-21 12:02                           ` Mark Rutland
2016-01-21 12:02                             ` Mark Rutland
2016-01-22  6:23                             ` AKASHI Takahiro
2016-01-22  6:23                               ` AKASHI Takahiro
2016-01-22 11:13                               ` Mark Rutland
2016-01-22 11:13                                 ` Mark Rutland
2016-02-02  5:18                                 ` AKASHI Takahiro
2016-02-02  5:18                                   ` AKASHI Takahiro
2016-01-25  3:19                               ` Dave Young
2016-01-25  3:19                                 ` Dave Young
2016-01-25  4:23                                 ` Dave Young
2016-01-25  4:23                                   ` Dave Young
2016-01-20 11:28                     ` Mark Rutland
2016-01-20 11:28                       ` Mark Rutland
2016-01-21  2:54                       ` Dave Young
2016-01-21  2:54                         ` Dave Young
2016-01-20  5:25                   ` AKASHI Takahiro
2016-01-20  5:25                     ` AKASHI Takahiro
2016-01-20 12:02                     ` Mark Rutland
2016-01-20 12:02                       ` Mark Rutland
2016-01-20 12:36                       ` Mark Rutland
2016-01-20 12:36                         ` Mark Rutland
2016-01-20 14:59                         ` Ard Biesheuvel
2016-01-20 14:59                           ` Ard Biesheuvel
2016-01-20 15:04                           ` Mark Rutland
2016-01-20 15:04                             ` Mark Rutland
2016-01-21  5:43                           ` AKASHI Takahiro
2016-01-21  5:43                             ` AKASHI Takahiro
2016-01-21 13:02                             ` Mark Rutland
2016-01-21 13:02                               ` Mark Rutland
2016-01-19 12:17         ` Mark Rutland
2016-01-19 12:17           ` Mark Rutland
2016-01-19 13:52           ` Dave Young
2016-01-19 13:52             ` Dave Young
2016-01-19 14:05             ` Mark Rutland
2016-01-19 14:05               ` Mark Rutland
2016-01-20  2:54               ` Dave Young
2016-01-20  2:54                 ` Dave Young
2016-01-15 19:18 ` [PATCH 14/19] arm64: kdump: reserve memory for crash dump kernel Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 13/19] arm64/kexec: Add pr_debug output Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 15/19] arm64: kdump: implement machine_crash_shutdown() Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 12/19] arm64/kexec: Enable kexec in the arm64 defconfig Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 11/19] arm64/kexec: Add core kexec support Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-15 19:18 ` [PATCH 19/19] arm64: kdump: relax BUG_ON() if more than one cpus are still active Geoff Levand
2016-01-15 19:18   ` Geoff Levand
2016-01-19 12:32 ` [PATCH 00/19] arm64 kexec kernel patches v13 Dave Young
2016-01-19 12:32   ` Dave Young
2016-01-20  0:15   ` Geoff Levand
2016-01-20  0:15     ` Geoff Levand
2016-01-20  2:56     ` Dave Young
2016-01-20  2:56       ` Dave Young
2016-01-20 21:15       ` Geoff Levand
2016-01-20 21:15         ` Geoff Levand
2016-01-21 12:11       ` Mark Rutland
2016-01-21 12:11         ` Mark Rutland
     [not found] ` <c7575f853ccc491bb0212e025aab1cc9@NASANEXM01H.na.qualcomm.com>
2016-03-01 17:54   ` Azriel Samson
2016-03-01 17:54     ` Azriel Samson
2016-03-02  1:17     ` Geoff Levand
2016-03-02  1:17       ` Geoff Levand
2016-03-02  1:38       ` Will Deacon
2016-03-02  1:38         ` Will Deacon
2016-03-02  2:28         ` AKASHI Takahiro
2016-03-02  2:28           ` AKASHI Takahiro
2016-03-02  8:07       ` Marc Zyngier
2016-03-02  8:07         ` Marc Zyngier
2016-03-02 12:33     ` Pratyush Anand
2016-03-02 12:33       ` Pratyush Anand
2016-03-02 16:51       ` Azriel Samson
2016-03-02 16:51         ` Azriel Samson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160115195517.GP3262@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@linaro.org \
    --cc=geoff@infradead.org \
    --cc=james.morse@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.