All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8
Date: Sun, 17 Jan 2016 15:38:06 +0100	[thread overview]
Message-ID: <20160117153806.6baea4a0@free-electrons.com> (raw)
In-Reply-To: <1453038796-7041-1-git-send-email-bernd.kuhls@t-online.de>

Bernd,

On Sun, 17 Jan 2016 14:53:16 +0100, Bernd Kuhls wrote:

> diff --git a/package/libbroadvoice/Config.in b/package/libbroadvoice/Config.in
> index d695df0..3301ba8 100644
> --- a/package/libbroadvoice/Config.in
> +++ b/package/libbroadvoice/Config.in
> @@ -1,5 +1,8 @@
>  config BR2_PACKAGE_LIBBROADVOICE
>  	bool "libbroadvoice"
> +	# broken with gcc <= 4.8 on arc
> +	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> +	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

If the bug affects gcc 4.8, and ARC currently uses gcc 4.8, why do you
need the "!BR2_arc" part of the condition ?

Doing:

	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9

is sufficient, and will ensure that this package will be built again
once ARC is moved to a gcc 4.9 based toolchain.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-17 14:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 13:53 [Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8 Bernd Kuhls
2016-01-17 14:38 ` Thomas Petazzoni [this message]
2016-01-17 15:34   ` Bernd Kuhls
2016-01-17 20:27 ` Arnout Vandecappelle
2016-01-19 21:21 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160117153806.6baea4a0@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.