All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8
Date: Sun, 17 Jan 2016 21:27:03 +0100	[thread overview]
Message-ID: <569BF917.2000501@mind.be> (raw)
In-Reply-To: <1453038796-7041-1-git-send-email-bernd.kuhls@t-online.de>

On 17-01-16 14:53, Bernd Kuhls wrote:
> Please read this bug report for details:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> 
> Fixes
> http://autobuild.buildroot.net/results/4a1/4a1fd92d1ce4963d3e282ea2dc8f0f6c5db4f1e1/
> http://autobuild.buildroot.net/results/ce3/ce3be7d27489647a98d8932c5bcabd08c845187b/
> http://autobuild.buildroot.net/results/988/988bd189bab37a03c037160d6758774d4aa6c8a0/
> and many others
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 ThomasP: this really is the intended condition.

 Note that we could add a comment saying that it needs gcc 4.9 on ARC, but that
would be pointless since you can't currently select gcc 4.9 on ARC...

 Regards,
 Arnout


> ---
> v2: changed logic to "material implication" (Arnout, Mason)
> 
>  package/libbroadvoice/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libbroadvoice/Config.in b/package/libbroadvoice/Config.in
> index d695df0..3301ba8 100644
> --- a/package/libbroadvoice/Config.in
> +++ b/package/libbroadvoice/Config.in
> @@ -1,5 +1,8 @@
>  config BR2_PACKAGE_LIBBROADVOICE
>  	bool "libbroadvoice"
> +	# broken with gcc <= 4.8 on arc
> +	# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59049
> +	depends on !BR2_arc || BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
>  	help
>  	  broadvoice - a library for the BroadVoice 16 and 32 speech
>  	  codecs
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  parent reply	other threads:[~2016-01-17 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-17 13:53 [Buildroot] [PATCH v2] package/libbroadvoice: Broken on BR2_arc with gcc <= 4.8 Bernd Kuhls
2016-01-17 14:38 ` Thomas Petazzoni
2016-01-17 15:34   ` Bernd Kuhls
2016-01-17 20:27 ` Arnout Vandecappelle [this message]
2016-01-19 21:21 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569BF917.2000501@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.