All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] iputils: resolve musl compatibility
Date: Mon, 18 Jan 2016 13:50:18 +0100	[thread overview]
Message-ID: <20160118135018.5a4804fa@free-electrons.com> (raw)
In-Reply-To: <1453089044-10391-1-git-send-email-matt@thewebers.ws>

Dear Matt Weber,

On Mon, 18 Jan 2016 03:50:44 +0000, Matt Weber wrote:
> The new upstream and version bump resolves a series of musl build failures
> noted in the autobuilder log.
> 
> http://autobuild.buildroot.net/results/12cb73f3def95efe706bcd957bc2c091e7931d5a/
> 
> Signed-off-by: Matt Weber <matt@thewebers.ws>
> ---
> v1
>   - Updated to github upstream, selected merge from Nov 3 2015
>     which provided musl fixes (last release was to old, 20150815)
>   - Added missing dependencies for kernel capabilies lib
>   - Accounted for new consolidated ping (ipv4/6)

Why aren't those comments part of the commit log? They detail the patch
itself, not changes between versions of the patch.

> Tested against a buildroot arm musl/glibc toolchains, as well as
> autobuilder defconfig.

Ditto.

> diff --git a/package/iputils/Config.in b/package/iputils/Config.in
> index 5324639..61681e4 100644
> --- a/package/iputils/Config.in
> +++ b/package/iputils/Config.in
> @@ -1,9 +1,10 @@
>  config BR2_PACKAGE_IPUTILS
>  	bool "iputils"
>  	select BR2_PACKAGE_OPENSSL
> +	select BR2_PACKAGE_LIBCAP

So you need to duplicate the dependencies of libcap in iputils
Config.in file.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-18 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  3:50 [Buildroot] [PATCH 1/1] iputils: resolve musl compatibility Matt Weber
2016-01-18 12:50 ` Thomas Petazzoni [this message]
2016-01-19 21:13 ` Thomas Petazzoni
2016-01-20  3:04   ` Matthew Weber
2016-01-20  8:44     ` Thomas Petazzoni
2016-01-20 12:21       ` Matthew Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160118135018.5a4804fa@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.