From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] iputils: resolve musl compatibility
Date: Tue, 19 Jan 2016 22:13:24 +0100 [thread overview]
Message-ID: <20160119221324.74332232@free-electrons.com> (raw)
In-Reply-To: <1453089044-10391-1-git-send-email-matt@thewebers.ws>
Matt,
Some more comments (see below).
On Mon, 18 Jan 2016 03:50:44 +0000, Matt Weber wrote:
> diff --git a/package/iputils/iputils.hash b/package/iputils/iputils.hash
> index 21a2044..fcca52c 100644
> --- a/package/iputils/iputils.hash
> +++ b/package/iputils/iputils.hash
> @@ -1,2 +1,4 @@
> +# Locally computed
> +sha256 0e98cb527fa175d1e08afb969c124e452b30968f10ec2c3b078f1440c8977a94 iputils-c8ff6feaf0442f8efd96ccb415770c54f9e84d47.tar.gz
> # From http://sourceforge.net/projects/iputils/files/
> sha1 3e85179746fd93000d6267bd55addfe97f321ba7 iputils-s20121011.tar.bz2
Why are you keeping the hash for the old tarball ?
> diff --git a/package/iputils/iputils.mk b/package/iputils/iputils.mk
> index 7510d99..d427b11 100644
> --- a/package/iputils/iputils.mk
> +++ b/package/iputils/iputils.mk
> @@ -4,13 +4,12 @@
> #
> ################################################################################
>
> -IPUTILS_VERSION = s20121011
> -IPUTILS_SITE = http://www.skbuff.net/iputils
> -IPUTILS_SOURCE = iputils-$(IPUTILS_VERSION).tar.bz2
> -IPUTILS_LICENSE = GPLv2+, BSD-3c
> +IPUTILS_VERSION = c8ff6feaf0442f8efd96ccb415770c54f9e84d47
> +IPUTILS_SITE = $(call github,iputils,iputils,$(IPUTILS_VERSION))
I don't understand why you are moving to github.
http://www.skbuff.net/iputils has some recent tarballs, which
correspond to the releases made on github.
http://www.skbuff.net/iputils/iputils-s20151218.tar.bz2 will most
likely contain the musl fixes.
I'll mark your patch as Changes Requested in patchwork. Can you respin
after fixing the issues raised during the review?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-01-19 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 3:50 [Buildroot] [PATCH 1/1] iputils: resolve musl compatibility Matt Weber
2016-01-18 12:50 ` Thomas Petazzoni
2016-01-19 21:13 ` Thomas Petazzoni [this message]
2016-01-20 3:04 ` Matthew Weber
2016-01-20 8:44 ` Thomas Petazzoni
2016-01-20 12:21 ` Matthew Weber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119221324.74332232@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.