From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Srikar Dronamraju
<srikar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Cc: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: v4.4-rc8 based tip tree kernel hangs on boot.
Date: Mon, 18 Jan 2016 15:40:01 +0000 [thread overview]
Message-ID: <20160118154001.GA2607@codeblueprint.co.uk> (raw)
In-Reply-To: <20160117173248.GA28841-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
On Sun, 17 Jan, at 11:02:48PM, Srikar Dronamraju wrote:
>
> Unfortunately even with your below patch on top of c9f2a9a ("x86/efi:
> Hoist page table switching code into efi_call_virt()" also fails to boot
> with and without CONFIG_DEBUG_WX=y. I have added CONFIG_EFI_PGT_DUMP.
What about if you comment out the call to efi_dump_pagetable()? What
if you return early from efi_sync_low_kernel_mappings(), e.g.
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index 71121a9d06cf..e1f8ebb88f84 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -177,6 +177,8 @@ void efi_sync_low_kernel_mappings(void)
init_mm.pgd + pgd_index(PAGE_OFFSET),
sizeof(pgd_t) * num_pgds);
+ return;
+
/*
* We can share all PGD entries apart from the one entry that
* covers the EFI runtime mapping space.
Do either of those modifications make your kernel boot when you apply
the patch I sent on Friday? If so, which one? I'm struggling to find
hardware that's similar enough to reproduce this.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: v4.4-rc8 based tip tree kernel hangs on boot.
Date: Mon, 18 Jan 2016 15:40:01 +0000 [thread overview]
Message-ID: <20160118154001.GA2607@codeblueprint.co.uk> (raw)
In-Reply-To: <20160117173248.GA28841@linux.vnet.ibm.com>
On Sun, 17 Jan, at 11:02:48PM, Srikar Dronamraju wrote:
>
> Unfortunately even with your below patch on top of c9f2a9a ("x86/efi:
> Hoist page table switching code into efi_call_virt()" also fails to boot
> with and without CONFIG_DEBUG_WX=y. I have added CONFIG_EFI_PGT_DUMP.
What about if you comment out the call to efi_dump_pagetable()? What
if you return early from efi_sync_low_kernel_mappings(), e.g.
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index 71121a9d06cf..e1f8ebb88f84 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -177,6 +177,8 @@ void efi_sync_low_kernel_mappings(void)
init_mm.pgd + pgd_index(PAGE_OFFSET),
sizeof(pgd_t) * num_pgds);
+ return;
+
/*
* We can share all PGD entries apart from the one entry that
* covers the EFI runtime mapping space.
Do either of those modifications make your kernel boot when you apply
the patch I sent on Friday? If so, which one? I'm struggling to find
hardware that's similar enough to reproduce this.
next prev parent reply other threads:[~2016-01-18 15:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 19:29 v4.4-rc8 based tip tree kernel hangs on boot Srikar Dronamraju
2016-01-10 19:29 ` Srikar Dronamraju
2016-01-11 14:01 ` Matt Fleming
[not found] ` <20160111140140.GA2644-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-01-11 15:10 ` Ingo Molnar
2016-01-11 15:10 ` Ingo Molnar
[not found] ` <20160111151030.GA23096-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-11 16:47 ` Srikar Dronamraju
2016-01-11 16:47 ` Srikar Dronamraju
2016-01-12 10:30 ` Ingo Molnar
2016-01-12 10:30 ` Ingo Molnar
2016-01-14 12:25 ` Matt Fleming
[not found] ` <20160112103043.GA5707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-15 16:20 ` Srikar Dronamraju
2016-01-15 16:20 ` Srikar Dronamraju
[not found] ` <20160115162011.GA2935-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-01-15 22:29 ` Matt Fleming
2016-01-15 22:29 ` Matt Fleming
2016-01-17 17:32 ` Srikar Dronamraju
[not found] ` <20160117173248.GA28841-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-01-18 15:40 ` Matt Fleming [this message]
2016-01-18 15:40 ` Matt Fleming
2016-01-19 10:47 ` Srikar Dronamraju
[not found] ` <20160119104715.GA15850-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2016-01-19 15:42 ` Matt Fleming
2016-01-19 15:42 ` Matt Fleming
[not found] ` <20160119154241.GA3615-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-01-19 18:17 ` Srikar Dronamraju
2016-01-19 18:17 ` Srikar Dronamraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118154001.GA2607@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mingo-X9Un+BFzKDI@public.gmane.org \
--cc=srikar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.