From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Maninder Singh <maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vdavydov-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org,
vbabka-AlSwsSmVLrQ@public.gmane.org,
baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ajeet.y-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
pankaj.m-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
Vaneet Narang <v.narang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.
Date: Mon, 18 Jan 2016 17:14:27 -0500 [thread overview]
Message-ID: <20160118221427.GA8657@cmpxchg.org> (raw)
In-Reply-To: <1453101492-37125-1-git-send-email-maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote:
> Replacing hardcoded values with enum lru_stats for LRU stats.
>
> Signed-off-by: Maninder Singh <maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Vaneet Narang <v.narang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
I don't think the code is hard to understand, it always says 'anon' or
'file' or similar for every context where it's important to understand
what the magic array index means.
And this patch makes the lines too long and unwieldy.
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: mhocko@kernel.org, vdavydov@virtuozzo.com,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, baiyaowei@cmss.chinamobile.com,
dan.j.williams@intel.com, tj@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
ajeet.y@samsung.com, pankaj.m@samsung.com,
Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.
Date: Mon, 18 Jan 2016 17:14:27 -0500 [thread overview]
Message-ID: <20160118221427.GA8657@cmpxchg.org> (raw)
In-Reply-To: <1453101492-37125-1-git-send-email-maninder1.s@samsung.com>
On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote:
> Replacing hardcoded values with enum lru_stats for LRU stats.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
I don't think the code is hard to understand, it always says 'anon' or
'file' or similar for every context where it's important to understand
what the magic array index means.
And this patch makes the lines too long and unwieldy.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: mhocko@kernel.org, vdavydov@virtuozzo.com,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, baiyaowei@cmss.chinamobile.com,
dan.j.williams@intel.com, tj@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
ajeet.y@samsung.com, pankaj.m@samsung.com,
Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH 1/1] mmzone: code cleanup for LRU stats.
Date: Mon, 18 Jan 2016 17:14:27 -0500 [thread overview]
Message-ID: <20160118221427.GA8657@cmpxchg.org> (raw)
In-Reply-To: <1453101492-37125-1-git-send-email-maninder1.s@samsung.com>
On Mon, Jan 18, 2016 at 12:48:12PM +0530, Maninder Singh wrote:
> Replacing hardcoded values with enum lru_stats for LRU stats.
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Signed-off-by: Vaneet Narang <v.narang@samsung.com>
I don't think the code is hard to understand, it always says 'anon' or
'file' or similar for every context where it's important to understand
what the magic array index means.
And this patch makes the lines too long and unwieldy.
next prev parent reply other threads:[~2016-01-18 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 7:18 [PATCH 1/1] mmzone: code cleanup for LRU stats Maninder Singh
2016-01-18 7:18 ` Maninder Singh
2016-01-18 7:18 ` Maninder Singh
[not found] ` <1453101492-37125-1-git-send-email-maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-01-18 22:14 ` Johannes Weiner [this message]
2016-01-18 22:14 ` Johannes Weiner
2016-01-18 22:14 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160118221427.GA8657@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=ajeet.y-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=baiyaowei-0p4V/sDNsUmm0O/7XYngnFaTQe2KTcn/@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=maninder1.s-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=pankaj.m-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=v.narang-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=vbabka-AlSwsSmVLrQ@public.gmane.org \
--cc=vdavydov-5HdwGun5lf+gSpxsJD1C4w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.