From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/1] USB: core: let USB device know device node
Date: Tue, 19 Jan 2016 10:52:54 +0800 [thread overview]
Message-ID: <20160119025254.GA24548@shlinux2> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1601181129340.25155-100000@netrider.rowland.org>
On Mon, Jan 18, 2016 at 11:39:06AM -0500, Alan Stern wrote:
> On Mon, 18 Jan 2016, Peter Chen wrote:
>
> > > > Why can't the root_hub reuse dev->dev.of_node?
> > >
> > > Indeed, there's no need to add an .of_node field to struct usb_device,
> > > since the embedded struct device already contains an .of_node field.
> > >
> >
> > No, the usb_device needs the .of_node field.
>
> It already _has_ an .of_node field, in its embedded struct device.
>
> > The devices belong to platform bus contains device node.
> > The devices (usb device) belong to USB bus which are created
> > dynamically do not contain device node.
>
> I don't know what you mean. struct usb_device _does_ contain an
> embedded struct device. It doesn't matter the structures are created
> dynamically, statically, or any other way; this field is part of the
> structure definition.
>
> Suppose udev is a pointer to struct usb_device. Then udev->dev is a
> struct device and udev->dev.of_node is a pointer to struct device_node.
> You don't need to add a new udev->of_node field; just use
> udev->dev.of_node instead.
>
Yes, you are right.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Alan Stern <stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>
Cc: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org,
s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 1/1] USB: core: let USB device know device node
Date: Tue, 19 Jan 2016 10:52:54 +0800 [thread overview]
Message-ID: <20160119025254.GA24548@shlinux2> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1601181129340.25155-100000-pYrvlCTfrz9XsRXLowluHWD2FQJk+8+b@public.gmane.org>
On Mon, Jan 18, 2016 at 11:39:06AM -0500, Alan Stern wrote:
> On Mon, 18 Jan 2016, Peter Chen wrote:
>
> > > > Why can't the root_hub reuse dev->dev.of_node?
> > >
> > > Indeed, there's no need to add an .of_node field to struct usb_device,
> > > since the embedded struct device already contains an .of_node field.
> > >
> >
> > No, the usb_device needs the .of_node field.
>
> It already _has_ an .of_node field, in its embedded struct device.
>
> > The devices belong to platform bus contains device node.
> > The devices (usb device) belong to USB bus which are created
> > dynamically do not contain device node.
>
> I don't know what you mean. struct usb_device _does_ contain an
> embedded struct device. It doesn't matter the structures are created
> dynamically, statically, or any other way; this field is part of the
> structure definition.
>
> Suppose udev is a pointer to struct usb_device. Then udev->dev is a
> struct device and udev->dev.of_node is a pointer to struct device_node.
> You don't need to add a new udev->of_node field; just use
> udev->dev.of_node instead.
>
Yes, you are right.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-19 2:52 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 9:17 [PATCH v3 1/1] USB: core: let USB device know device node Peter Chen
2016-01-15 9:17 ` Peter Chen
2016-01-15 11:11 ` Arnd Bergmann
2016-01-15 11:11 ` Arnd Bergmann
2016-01-15 15:11 ` Alan Stern
2016-01-15 15:11 ` Alan Stern
2016-01-15 23:03 ` Arnd Bergmann
2016-01-15 23:03 ` Arnd Bergmann
2016-01-16 16:40 ` Alan Stern
2016-01-16 16:40 ` Alan Stern
2016-01-18 8:15 ` Peter Chen
2016-01-18 8:15 ` Peter Chen
2016-01-18 16:46 ` Alan Stern
2016-01-18 16:46 ` Alan Stern
2016-01-19 3:08 ` Peter Chen
2016-01-19 3:08 ` Peter Chen
2016-01-19 11:33 ` Arnd Bergmann
2016-01-19 11:33 ` Arnd Bergmann
2016-01-19 15:12 ` Alan Stern
2016-01-19 15:12 ` Alan Stern
2016-01-20 3:48 ` Peter Chen
2016-01-20 3:48 ` Peter Chen
2016-01-20 9:07 ` Arnd Bergmann
2016-01-20 9:07 ` Arnd Bergmann
2016-01-20 12:50 ` Peter Chen
2016-01-20 12:50 ` Peter Chen
2016-01-20 14:19 ` Arnd Bergmann
2016-01-20 14:19 ` Arnd Bergmann
2016-01-21 3:15 ` Peter Chen
2016-01-21 3:15 ` Peter Chen
2016-01-21 8:41 ` Arnd Bergmann
2016-01-21 8:41 ` Arnd Bergmann
2016-01-21 9:48 ` Peter Chen
2016-01-21 9:48 ` Peter Chen
2016-01-21 10:10 ` Arnd Bergmann
2016-01-21 10:10 ` Arnd Bergmann
2016-01-21 15:21 ` Alan Stern
2016-01-21 15:21 ` Alan Stern
2016-01-21 22:24 ` Arnd Bergmann
2016-01-21 22:24 ` Arnd Bergmann
2016-01-22 6:59 ` Peter Chen
2016-01-22 6:59 ` Peter Chen
2016-01-22 10:18 ` Arnd Bergmann
2016-01-22 10:18 ` Arnd Bergmann
2016-01-22 15:55 ` Alan Stern
2016-01-22 15:55 ` Alan Stern
2016-01-22 16:23 ` Arnd Bergmann
2016-01-22 16:23 ` Arnd Bergmann
2016-01-22 19:29 ` Alan Stern
2016-01-22 19:29 ` Alan Stern
2016-01-25 1:55 ` Peter Chen
2016-01-25 1:55 ` Peter Chen
2016-01-25 3:57 ` Peter Chen
2016-01-25 3:57 ` Peter Chen
2016-01-25 8:50 ` Arnd Bergmann
2016-01-25 8:50 ` Arnd Bergmann
2016-01-25 9:31 ` Peter Chen
2016-01-25 9:31 ` Peter Chen
2016-01-25 15:23 ` Alan Stern
2016-01-25 15:23 ` Alan Stern
2016-01-18 10:24 ` Arnd Bergmann
2016-01-18 10:24 ` Arnd Bergmann
2016-01-18 7:44 ` Peter Chen
2016-01-18 7:44 ` Peter Chen
2016-01-18 7:42 ` Peter Chen
2016-01-18 7:42 ` Peter Chen
2016-01-15 17:07 ` Philipp Zabel
2016-01-15 17:07 ` Philipp Zabel
2016-01-15 17:30 ` Alan Stern
2016-01-15 17:30 ` Alan Stern
2016-01-18 7:13 ` Peter Chen
2016-01-18 7:13 ` Peter Chen
2016-01-18 16:39 ` Alan Stern
2016-01-18 16:39 ` Alan Stern
2016-01-19 2:52 ` Peter Chen [this message]
2016-01-19 2:52 ` Peter Chen
2016-01-18 7:10 ` Peter Chen
2016-01-18 7:10 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119025254.GA24548@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.