From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms@verge.net.au>,
Valentine Barshak <valentine.barshak@cogentembedded.com>,
<linux-pci@vger.kernel.org>, <linux-sh@vger.kernel.org>
Subject: Re: [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas
Date: Mon, 18 Jan 2016 23:19:44 -0500 [thread overview]
Message-ID: <20160119041943.GB1696@windriver.com> (raw)
In-Reply-To: <20160108203737.GJ5354@localhost>
[Re: [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas] On 08/01/2016 (Fri 14:37) Bjorn Helgaas wrote:
> On Mon, Dec 21, 2015 at 07:59:07PM -0500, Paul Gortmaker wrote:
> > These two commits are extracted from what was a larger series[1] of
> > demodularization in PCI host code that was bool Kconfig.
> >
> > With the other commits, there was some mixed opinions whether we
> > should make it explicitly non-modular or move towards making it
> > functionally working as a tristate in order to reduce the size of
> > built-in code for multi-platform kernels.
> >
> > However with the renesas changes, there was no ".remove" and no
> > "module_exit" code stripped out ; it is just a straight 1:1 mapping
> > of the modular macros onto what they become in the non-modular case
> > anyway -- meaning the runtime remains unchanged.
>
> Is there any reason these drivers can't be made modular? I'd rather
> do that, if we can.
Per the above comments, the renesas drivers were a no-op and and got
Ack: from appropriate people hence why I forked them out of the earlier
bigger series, in thinking they were OK'd and done as-is.
That said, if "be modular, or die trying" is the desired approach for
PCI code, I can do my best to work within that constraint. It just
won't be the no-op 1:1 mapping that the original proposed changes were.
P.
--
>
> Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms@verge.net.au>,
Valentine Barshak <valentine.barshak@cogentembedded.com>,
linux-pci@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas
Date: Tue, 19 Jan 2016 04:19:44 +0000 [thread overview]
Message-ID: <20160119041943.GB1696@windriver.com> (raw)
In-Reply-To: <20160108203737.GJ5354@localhost>
[Re: [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas] On 08/01/2016 (Fri 14:37) Bjorn Helgaas wrote:
> On Mon, Dec 21, 2015 at 07:59:07PM -0500, Paul Gortmaker wrote:
> > These two commits are extracted from what was a larger series[1] of
> > demodularization in PCI host code that was bool Kconfig.
> >
> > With the other commits, there was some mixed opinions whether we
> > should make it explicitly non-modular or move towards making it
> > functionally working as a tristate in order to reduce the size of
> > built-in code for multi-platform kernels.
> >
> > However with the renesas changes, there was no ".remove" and no
> > "module_exit" code stripped out ; it is just a straight 1:1 mapping
> > of the modular macros onto what they become in the non-modular case
> > anyway -- meaning the runtime remains unchanged.
>
> Is there any reason these drivers can't be made modular? I'd rather
> do that, if we can.
Per the above comments, the renesas drivers were a no-op and and got
Ack: from appropriate people hence why I forked them out of the earlier
bigger series, in thinking they were OK'd and done as-is.
That said, if "be modular, or die trying" is the desired approach for
PCI code, I can do my best to work within that constraint. It just
won't be the no-op 1:1 mapping that the original proposed changes were.
P.
--
>
> Bjorn
next prev parent reply other threads:[~2016-01-19 4:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 0:59 [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas Paul Gortmaker
2015-12-22 0:59 ` Paul Gortmaker
2015-12-22 0:59 ` [PATCH 1/2] drivers/pci: make host/pcie-rcar.c explicitly non-modular Paul Gortmaker
2015-12-22 0:59 ` Paul Gortmaker
2015-12-22 8:30 ` Geert Uytterhoeven
2015-12-22 8:30 ` Geert Uytterhoeven
2015-12-22 16:20 ` Paul Gortmaker
2015-12-22 16:20 ` Paul Gortmaker
2015-12-22 0:59 ` [PATCH 2/2] drivers/pci: make host/pci-rcar-gen2.c " Paul Gortmaker
2015-12-22 0:59 ` Paul Gortmaker
2016-01-08 20:37 ` [PATCH 0/2] drivers/pci: use builtin_platform_driver in renesas Bjorn Helgaas
2016-01-08 20:37 ` Bjorn Helgaas
2016-01-19 4:19 ` Paul Gortmaker [this message]
2016-01-19 4:19 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119041943.GB1696@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.