From: Minchan Kim <minchan@kernel.org>
To: Russell Knize <rknize@motorola.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Junil Lee <junil0814.lee@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
ngupta@vflare.org, linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zsmalloc: fix migrate_zspage-zs_free race condition
Date: Wed, 20 Jan 2016 16:00:19 +0900 [thread overview]
Message-ID: <20160120070019.GC12293@bbox> (raw)
In-Reply-To: <CAGfvh60CYegQ1fRMzuWbRNsv5eYEEiXtXFSBr_CbnJHuYMs5pQ@mail.gmail.com>
Hello Russ,
On Tue, Jan 19, 2016 at 09:47:12AM -0600, Russell Knize wrote:
> Just wanted to ack this, as we have been seeing the same problem (weird
> race conditions during compaction) and fixed it in the same way a few
> weeks ago (resetting the pin bit before recording the obj).
> Russ
First of all, thanks for your comment.
The patch you tested have a problem although it's really subtle(ie,
it doesn't do store tearing when I disassemble ARM{32|64}) but it
could have a problem potentially for other architecutres or future ARM.
For right fix, I sent v5 - https://lkml.org/lkml/2016/1/18/263.
If you can prove it fixes your problem, please Tested-by to the thread.
It's really valuable to do testing for stable material.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Russell Knize <rknize@motorola.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Junil Lee <junil0814.lee@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
ngupta@vflare.org, linux-mm@kvack.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zsmalloc: fix migrate_zspage-zs_free race condition
Date: Wed, 20 Jan 2016 16:00:19 +0900 [thread overview]
Message-ID: <20160120070019.GC12293@bbox> (raw)
In-Reply-To: <CAGfvh60CYegQ1fRMzuWbRNsv5eYEEiXtXFSBr_CbnJHuYMs5pQ@mail.gmail.com>
Hello Russ,
On Tue, Jan 19, 2016 at 09:47:12AM -0600, Russell Knize wrote:
> Just wanted to ack this, as we have been seeing the same problem (weird
> race conditions during compaction) and fixed it in the same way a few
> weeks ago (resetting the pin bit before recording the obj).
> Russ
First of all, thanks for your comment.
The patch you tested have a problem although it's really subtle(ie,
it doesn't do store tearing when I disassemble ARM{32|64}) but it
could have a problem potentially for other architecutres or future ARM.
For right fix, I sent v5 - https://lkml.org/lkml/2016/1/18/263.
If you can prove it fixes your problem, please Tested-by to the thread.
It's really valuable to do testing for stable material.
Thanks!
next prev parent reply other threads:[~2016-01-20 6:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 0:36 [PATCH] zsmalloc: fix migrate_zspage-zs_free race condition Junil Lee
2016-01-15 0:36 ` Junil Lee
2016-01-15 2:35 ` Minchan Kim
2016-01-15 2:35 ` Minchan Kim
2016-01-15 3:27 ` Sergey Senozhatsky
2016-01-15 3:27 ` Sergey Senozhatsky
2016-01-15 3:30 ` Sergey Senozhatsky
2016-01-15 3:30 ` Sergey Senozhatsky
2016-01-15 4:49 ` Minchan Kim
2016-01-15 4:49 ` Minchan Kim
2016-01-15 5:07 ` Sergey Senozhatsky
2016-01-15 5:07 ` Sergey Senozhatsky
2016-01-19 15:47 ` Russell Knize
2016-01-20 7:00 ` Minchan Kim [this message]
2016-01-20 7:00 ` Minchan Kim
2016-01-20 15:21 ` Russell Knize
2016-01-20 15:21 ` Russell Knize
2016-01-15 5:05 ` Minchan Kim
2016-01-15 5:05 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120070019.GC12293@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=junil0814.lee@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=rknize@motorola.com \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.