All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names
Date: Wed, 20 Jan 2016 10:07:26 +0100	[thread overview]
Message-ID: <20160120100726.46dc8816@free-electrons.com> (raw)
In-Reply-To: <1453277183-5412-5-git-send-email-jszhang@marvell.com>

Dear Jisheng Zhang,

On Wed, 20 Jan 2016 16:06:23 +0800, Jisheng Zhang wrote:

> diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> index aeea50c..f85b93b 100644
> --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> @@ -6,12 +6,16 @@ Required properties:
>  - interrupts: interrupt for the device
>  - phy: See ethernet.txt file in the same directory.
>  - phy-mode: See ethernet.txt file in the same directory
> -- clocks: a pointer to the reference clock for this device.
> +- clocks: Array of clocks required for this device; requires at least one
> +  for CORE clock.

Rather than "Array", I would say "list", so what about:

 - clocks: List of clocks for this device. At least one clock is
   mandatory for the core clock. If several clocks are given, then the
   clock-names property must be used to identify them.

>  Optional properties:
>  - tx-csum-limit: maximum mtu supported by port that allow TX checksum.
>    Value is presented in bytes. If not used, by default 1600B is set for
>    "marvell,armada-370-neta" and 9800B for others.
> +- clock-names: Array of names corresponding to clocks property; shall be
> +  "core" for CORE clock and "axi" for optional AXI clock.

Array -> List.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh+dt@kernel.org, galak@codeaurora.org, mw@semihalf.com,
	davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
	sebastian.hesselbarth@gmail.com
Subject: Re: [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names
Date: Wed, 20 Jan 2016 10:07:26 +0100	[thread overview]
Message-ID: <20160120100726.46dc8816@free-electrons.com> (raw)
In-Reply-To: <1453277183-5412-5-git-send-email-jszhang@marvell.com>

Dear Jisheng Zhang,

On Wed, 20 Jan 2016 16:06:23 +0800, Jisheng Zhang wrote:

> diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> index aeea50c..f85b93b 100644
> --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> @@ -6,12 +6,16 @@ Required properties:
>  - interrupts: interrupt for the device
>  - phy: See ethernet.txt file in the same directory.
>  - phy-mode: See ethernet.txt file in the same directory
> -- clocks: a pointer to the reference clock for this device.
> +- clocks: Array of clocks required for this device; requires at least one
> +  for CORE clock.

Rather than "Array", I would say "list", so what about:

 - clocks: List of clocks for this device. At least one clock is
   mandatory for the core clock. If several clocks are given, then the
   clock-names property must be used to identify them.

>  Optional properties:
>  - tx-csum-limit: maximum mtu supported by port that allow TX checksum.
>    Value is presented in bytes. If not used, by default 1600B is set for
>    "marvell,armada-370-neta" and 9800B for others.
> +- clock-names: Array of names corresponding to clocks property; shall be
> +  "core" for CORE clock and "axi" for optional AXI clock.

Array -> List.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: <davem@davemloft.net>, <mw@semihalf.com>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <sebastian.hesselbarth@gmail.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names
Date: Wed, 20 Jan 2016 10:07:26 +0100	[thread overview]
Message-ID: <20160120100726.46dc8816@free-electrons.com> (raw)
In-Reply-To: <1453277183-5412-5-git-send-email-jszhang@marvell.com>

Dear Jisheng Zhang,

On Wed, 20 Jan 2016 16:06:23 +0800, Jisheng Zhang wrote:

> diff --git a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> index aeea50c..f85b93b 100644
> --- a/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> +++ b/Documentation/devicetree/bindings/net/marvell-armada-370-neta.txt
> @@ -6,12 +6,16 @@ Required properties:
>  - interrupts: interrupt for the device
>  - phy: See ethernet.txt file in the same directory.
>  - phy-mode: See ethernet.txt file in the same directory
> -- clocks: a pointer to the reference clock for this device.
> +- clocks: Array of clocks required for this device; requires at least one
> +  for CORE clock.

Rather than "Array", I would say "list", so what about:

 - clocks: List of clocks for this device. At least one clock is
   mandatory for the core clock. If several clocks are given, then the
   clock-names property must be used to identify them.

>  Optional properties:
>  - tx-csum-limit: maximum mtu supported by port that allow TX checksum.
>    Value is presented in bytes. If not used, by default 1600B is set for
>    "marvell,armada-370-neta" and 9800B for others.
> +- clock-names: Array of names corresponding to clocks property; shall be
> +  "core" for CORE clock and "axi" for optional AXI clock.

Array -> List.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-01-20  9:07 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20  8:06 [PATCH 0/4] net: mvneta: support more than one clk Jisheng Zhang
2016-01-20  8:06 ` Jisheng Zhang
2016-01-20  8:06 ` Jisheng Zhang
2016-01-20  8:06 ` Jisheng Zhang
2016-01-20  8:06 ` [PATCH 1/4] net: mvneta: sort the headers in alphabetic order Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:46   ` Thomas Petazzoni
2016-01-20  8:46     ` Thomas Petazzoni
2016-01-20  8:46     ` Thomas Petazzoni
2016-01-20  8:46     ` Thomas Petazzoni
2016-01-20  8:06 ` [PATCH 2/4] net: mvneta: Try to get named core clock first Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:47   ` Thomas Petazzoni
2016-01-20  8:47     ` Thomas Petazzoni
2016-01-20  8:47     ` Thomas Petazzoni
2016-01-20  8:47     ` Thomas Petazzoni
2016-01-20  8:06 ` [PATCH 3/4] net: mvneta: mmc: get optional axi clk Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:51   ` Thomas Petazzoni
2016-01-20  8:51     ` Thomas Petazzoni
2016-01-20  8:51     ` Thomas Petazzoni
2016-01-20  8:53     ` Jisheng Zhang
2016-01-20  8:53       ` Jisheng Zhang
2016-01-20  8:53       ` Jisheng Zhang
2016-01-20  9:31   ` Sebastian Hesselbarth
2016-01-20  9:31     ` Sebastian Hesselbarth
2016-01-20  9:31     ` Sebastian Hesselbarth
2016-01-20  9:31     ` Sebastian Hesselbarth
2016-01-20  9:42     ` Jisheng Zhang
2016-01-20  9:42       ` Jisheng Zhang
2016-01-20  9:42       ` Jisheng Zhang
2016-01-20  9:42       ` Jisheng Zhang
2016-01-20 11:03       ` Sebastian Hesselbarth
2016-01-20 11:03         ` Sebastian Hesselbarth
2016-01-20 11:03         ` Sebastian Hesselbarth
2016-01-20 11:11         ` Jisheng Zhang
2016-01-20 11:11           ` Jisheng Zhang
2016-01-20 11:11           ` Jisheng Zhang
2016-01-20 11:11           ` Jisheng Zhang
2016-01-20  8:06 ` [PATCH 4/4] net: mvneta: update clocks property and document additional clock-names Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  8:06   ` Jisheng Zhang
2016-01-20  9:07   ` Thomas Petazzoni [this message]
2016-01-20  9:07     ` Thomas Petazzoni
2016-01-20  9:07     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160120100726.46dc8816@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.