From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option
Date: Wed, 20 Jan 2016 19:25:13 +0200 [thread overview]
Message-ID: <20160120192229-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <20160120171504.GB4218@thinpad.lan.raisama.net>
On Wed, Jan 20, 2016 at 03:15:04PM -0200, Eduardo Habkost wrote:
> On Wed, Jan 20, 2016 at 01:34:29PM -0200, Eduardo Habkost wrote:
> [...]
> > Considering that we never supported
> > gigabyte_align && max_ram_below_4g > 3G ||
> > max_ram_below_4g > 3.5G
> > before, we could simply remove the MachineClass::gigabyte_align
> > field from pc_piix, and just do the following:
> >
> > * pc > 1.7: max_ram_below_4g = 3G
> > (equivalent to gigabyte_align=true)
> > * pc <= 1.7: max_ram_below_4g = 3.5G
> > (equivalent to gigabyte_align=false)
>
> Ignore the suggestion above. I forgot that gigabyte_align applies
> only if ram_size > 3.5GB (so setting max_ram_below_4g = 3G on
> pc > 1.7 wouldn't work). So, unless somebody has a suggestion
> that makes this logic simpler:
I wonder whether we should just bite the bullet and ask management to
maintain the physical memory map for us, instead of trying to give us
hints.
Thoughts?
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> --
> Eduardo
next prev parent reply other threads:[~2016-01-20 17:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 12:58 [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option Gerd Hoffmann
2016-01-08 17:45 ` Igor Mammedov
2016-01-08 18:32 ` Laszlo Ersek
2016-01-11 8:26 ` Gerd Hoffmann
2016-01-11 12:16 ` Laszlo Ersek
2016-01-11 12:26 ` Marcel Apfelbaum
2016-01-14 23:45 ` Eric Blake
2016-01-19 12:37 ` Eduardo Habkost
2016-01-20 14:55 ` Gerd Hoffmann
2016-01-20 15:34 ` Eduardo Habkost
2016-01-20 17:15 ` Eduardo Habkost
2016-01-20 17:25 ` Michael S. Tsirkin [this message]
2016-01-21 7:48 ` Gerd Hoffmann
2016-01-21 9:37 ` Michael S. Tsirkin
2016-01-22 10:51 ` Gerd Hoffmann
2016-01-24 6:37 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2016-06-02 8:48 Gerd Hoffmann
2015-11-03 10:06 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160120192229-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.