From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option
Date: Thu, 14 Jan 2016 16:45:53 -0700 [thread overview]
Message-ID: <56983331.7090206@redhat.com> (raw)
In-Reply-To: <1452257883-19549-1-git-send-email-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 908 bytes --]
On 01/08/2016 05:58 AM, Gerd Hoffmann wrote:
> This patch extends the functionality of the max-ram-below-4g option
> to also allow increasing lowmem. Use case: Give as much memory as
> possible to legacy non-PAE guests.
>
> While being at it also rework the lowmem calculation logic and add a
> longish comment describing how it works and what the compatibility
> constrains are.
s/constrains/constraints/
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> + if (lowmem & ((1ULL << 30) - 1)) {
> + error_report("Warning: Large machine and max_ram_below_4g "
> + "(%" PRIu64 ") not a multiple of 1G; "
> + "possible bad performance.",
No trailing '.' in error_report(), please.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-14 23:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 12:58 [Qemu-devel] [PATCH v2] pc: allow raising low memory via max-ram-below-4g option Gerd Hoffmann
2016-01-08 17:45 ` Igor Mammedov
2016-01-08 18:32 ` Laszlo Ersek
2016-01-11 8:26 ` Gerd Hoffmann
2016-01-11 12:16 ` Laszlo Ersek
2016-01-11 12:26 ` Marcel Apfelbaum
2016-01-14 23:45 ` Eric Blake [this message]
2016-01-19 12:37 ` Eduardo Habkost
2016-01-20 14:55 ` Gerd Hoffmann
2016-01-20 15:34 ` Eduardo Habkost
2016-01-20 17:15 ` Eduardo Habkost
2016-01-20 17:25 ` Michael S. Tsirkin
2016-01-21 7:48 ` Gerd Hoffmann
2016-01-21 9:37 ` Michael S. Tsirkin
2016-01-22 10:51 ` Gerd Hoffmann
2016-01-24 6:37 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2016-06-02 8:48 Gerd Hoffmann
2015-11-03 10:06 Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56983331.7090206@redhat.com \
--to=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.