[PATCH 0/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[PATCH 0/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Robert Yang]

The following changes since commit 8084c185c43cb7e7f5e29d31939dfd308f8a0f93:

  udev: Add 2 patches to support 4.4 kernel (2016-01-20 09:20:06 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/rerun
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/rerun

Robert Yang (1):
  insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

 meta/classes/insane.bbclass |    1 +
 1 file changed, 1 insertion(+)

-- 
1.7.9.5

[PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Robert Yang]

do_package_qa() should rerun when WARN_QA or ERROR_QA changed

[YOCTO #8445]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/insane.bbclass |    1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index f7781ce..0ab756f 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -1098,6 +1098,7 @@ python do_package_qa () {
 
 do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
 do_package_qa[rdeptask] = "do_packagedata"
+do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
 addtask do_package_qa after do_packagedata do_package before do_build
 
 SSTATETASKS += "do_package_qa"
-- 
1.7.9.5

Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Olof Johansson]

On 16-01-21 00:11 -0800, Robert Yang wrote:
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -1098,6 +1098,7 @@ python do_package_qa () {
>  
>  do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
>  do_package_qa[rdeptask] = "do_packagedata"
> +do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"

Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded
values of the variables.

-- 
olofjn

Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Robert Yang]

On 01/21/2016 04:16 PM, Olof Johansson wrote:
> On 16-01-21 00:11 -0800, Robert Yang wrote:
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -1098,6 +1098,7 @@ python do_package_qa () {
>>
>>   do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
>>   do_package_qa[rdeptask] = "do_packagedata"
>> +do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
>
> Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded
> values of the variables.

Sorry, please drop this patch, need more work it.

// Robert

>

Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Paul Eggleton]

On Thu, 21 Jan 2016 16:42:00 Robert Yang wrote:
> On 01/21/2016 04:16 PM, Olof Johansson wrote:
> > On 16-01-21 00:11 -0800, Robert Yang wrote:
> >> --- a/meta/classes/insane.bbclass
> >> +++ b/meta/classes/insane.bbclass
> >> @@ -1098,6 +1098,7 @@ python do_package_qa () {
> >> 
> >>   do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
> >>   do_package_qa[rdeptask] = "do_packagedata"
> >> 
> >> +do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
> > 
> > Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded
> > values of the variables.
> 
> Sorry, please drop this patch, need more work it.

Aside from that, didn't we already have a discussion on whether changing these 
variables should force do_package_qa to re-execute? Ross, I seem to recall you 
were involved last time.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Richard Purdie]

On Fri, 2016-01-22 at 07:29 +1300, Paul Eggleton wrote:
> On Thu, 21 Jan 2016 16:42:00 Robert Yang wrote:
> > On 01/21/2016 04:16 PM, Olof Johansson wrote:
> > > On 16-01-21 00:11 -0800, Robert Yang wrote:
> > > > --- a/meta/classes/insane.bbclass
> > > > +++ b/meta/classes/insane.bbclass
> > > > @@ -1098,6 +1098,7 @@ python do_package_qa () {
> > > > 
> > > >   do_package_qa[vardepsexclude] = "BB_TASKDEPDATA"
> > > >   do_package_qa[rdeptask] = "do_packagedata"
> > > > 
> > > > +do_package_qa[vardeps] += "${WARN_QA} ${ERROR_QA}"
> > > 
> > > Shouldn't this be "WARN_QA ERROR_QA"? Or you'll get the expanded
> > > values of the variables.
> > 
> > Sorry, please drop this patch, need more work it.
> 
> Aside from that, didn't we already have a discussion on whether
> changing these 
> variables should force do_package_qa to re-execute? Ross, I seem to
> recall you 
> were involved last time.

Last time around we ended up with:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f6ec8dfaf7f98ade05d6292d2fea42805c4d80a7

Cheers,

Richard

Re: [PATCH 1/1] insane.bbclass: do_package_qa depends on WARN_QA and ERROR_QA

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On 21 January 2016 at 21:56, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> Last time around we ended up with:
>
>
> http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f6ec8dfaf7f98ade05d6292d2fea42805c4d80a7
>

Thank you, my brain was saying I'd done this already :)

Ross

[-- Attachment #2: Type: text/html, Size: 866 bytes --]