From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: tony.luck@intel.com, Rafael Aquini <aquini@redhat.com>,
KVM list <kvm@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Boqun Feng <boqun.feng@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
virtualization <virtualization@lists.linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes)
Date: Thu, 21 Jan 2016 12:23:07 +0200 [thread overview]
Message-ID: <20160121121544-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CA+55aFyh_1Lpp4U2wsFJQu_4PmSBD=36YeAhQN94L4GUhQrb2Q@mail.gmail.com>
On Mon, Jan 18, 2016 at 05:01:26PM -0800, Linus Torvalds wrote:
> On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Hi Linus,
> > Just making sure nothing's wrong with this pull request.
> > If there's an issue, pls let me know!
>
> It was just pulled because I wasn't 100% sure I wanted the extra
> indirection. Oh well, pulled now.
>
> One question:
>
> - the arch/sh/ part of the pacth looks dubious. Why does it do that
>
> #define smp_store_mb(var, value) __smp_store_mb(var, value)
>
> despite the commit log saying it's done by asm-generic?
>
> I haven't pushed out yet, my allmodconfig sanity-check build is still going..
>
> Linus
Oh that's because that's what the existing code did, so
the original version of the patch left the bug in place.
I wanted to include the fix and I wrote this in the
commit message, but I forgot to include it in the code :(
Thankfully this just means that the commit log is wrong,
the code is just unchanged from 4.4, and I'll
include a fix in my tree shortly.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: KVM list <kvm@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Duyck <alexander.duyck@gmail.com>,
Rafael Aquini <aquini@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Boqun Feng <boqun.feng@gmail.com>,
tony.luck@intel.com
Subject: Re: virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes)
Date: Thu, 21 Jan 2016 12:23:07 +0200 [thread overview]
Message-ID: <20160121121544-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CA+55aFyh_1Lpp4U2wsFJQu_4PmSBD=36YeAhQN94L4GUhQrb2Q@mail.gmail.com>
On Mon, Jan 18, 2016 at 05:01:26PM -0800, Linus Torvalds wrote:
> On Mon, Jan 18, 2016 at 5:21 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Hi Linus,
> > Just making sure nothing's wrong with this pull request.
> > If there's an issue, pls let me know!
>
> It was just pulled because I wasn't 100% sure I wanted the extra
> indirection. Oh well, pulled now.
>
> One question:
>
> - the arch/sh/ part of the pacth looks dubious. Why does it do that
>
> #define smp_store_mb(var, value) __smp_store_mb(var, value)
>
> despite the commit log saying it's done by asm-generic?
>
> I haven't pushed out yet, my allmodconfig sanity-check build is still going..
>
> Linus
Oh that's because that's what the existing code did, so
the original version of the patch left the bug in place.
I wanted to include the fix and I wrote this in the
commit message, but I forgot to include it in the code :(
Thankfully this just means that the commit log is wrong,
the code is just unchanged from 4.4, and I'll
include a fix in my tree shortly.
--
MST
next prev parent reply other threads:[~2016-01-21 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 16:28 [PULL] virtio: barrier rework+fixes Michael S. Tsirkin
2016-01-13 16:28 ` Michael S. Tsirkin
2016-01-18 13:21 ` virtio pull for 4.5 (was Re: [PULL] virtio: barrier rework+fixes) Michael S. Tsirkin
2016-01-18 19:07 ` Davidlohr Bueso
2016-01-19 1:01 ` Linus Torvalds
2016-01-19 1:01 ` Linus Torvalds
2016-01-21 10:23 ` Michael S. Tsirkin [this message]
2016-01-21 10:23 ` Michael S. Tsirkin
2016-01-19 1:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121121544-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=boqun.feng@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.