* [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
@ 2016-01-21 12:32 ` Lee, Chun-Yi
0 siblings, 0 replies; 4+ messages in thread
From: Lee, Chun-Yi @ 2016-01-21 12:32 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-nvdimm, linux-acpi, linux-kernel, Lee, Chun-Yi,
Ross Zwisler, Len Brown
It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
coded string.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
drivers/acpi/nfit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index aa45d48..9fb1a6a 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
acpi_size sz;
int rc;
- status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
+ status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
if (ACPI_FAILURE(status)) {
/* This is ok, we could have an nvdimm hotplugged later */
dev_dbg(dev, "failed to find NFIT at startup\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
@ 2016-01-21 12:32 ` Lee, Chun-Yi
0 siblings, 0 replies; 4+ messages in thread
From: Lee, Chun-Yi @ 2016-01-21 12:32 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: linux-nvdimm, linux-acpi, linux-kernel, Lee, Chun-Yi,
Ross Zwisler, Len Brown
It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
coded string.
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
drivers/acpi/nfit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
index aa45d48..9fb1a6a 100644
--- a/drivers/acpi/nfit.c
+++ b/drivers/acpi/nfit.c
@@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
acpi_size sz;
int rc;
- status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
+ status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
if (ACPI_FAILURE(status)) {
/* This is ok, we could have an nvdimm hotplugged later */
dev_dbg(dev, "failed to find NFIT at startup\n");
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
2016-01-21 12:32 ` Lee, Chun-Yi
@ 2016-01-21 16:08 ` Ross Zwisler
-1 siblings, 0 replies; 4+ messages in thread
From: Ross Zwisler @ 2016-01-21 16:08 UTC (permalink / raw)
To: Lee, Chun-Yi
Cc: Rafael J. Wysocki, linux-nvdimm, linux-acpi, linux-kernel,
Lee, Chun-Yi, Ross Zwisler, Len Brown
On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
> acpi_size sz;
> int rc;
>
> - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
> if (ACPI_FAILURE(status)) {
> /* This is ok, we could have an nvdimm hotplugged later */
> dev_dbg(dev, "failed to find NFIT at startup\n");
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string
@ 2016-01-21 16:08 ` Ross Zwisler
0 siblings, 0 replies; 4+ messages in thread
From: Ross Zwisler @ 2016-01-21 16:08 UTC (permalink / raw)
To: Lee, Chun-Yi
Cc: Rafael J. Wysocki, linux-nvdimm, linux-acpi, linux-kernel,
Lee, Chun-Yi, Ross Zwisler, Len Brown
On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
> acpi_size sz;
> int rc;
>
> - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
> if (ACPI_FAILURE(status)) {
> /* This is ok, we could have an nvdimm hotplugged later */
> dev_dbg(dev, "failed to find NFIT at startup\n");
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-21 16:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 12:32 [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string Lee, Chun-Yi
2016-01-21 12:32 ` Lee, Chun-Yi
2016-01-21 16:08 ` Ross Zwisler
2016-01-21 16:08 ` Ross Zwisler
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.