All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andrew W Elble <aweits@rit.edu>
Cc: linux-nfs@vger.kernel.org, dros@primarydata.com
Subject: Re: [PATCH v2 3/3] nfsd: implement machine credential support for some operations
Date: Thu, 21 Jan 2016 14:50:03 -0500	[thread overview]
Message-ID: <20160121195003.GD1793@fieldses.org> (raw)
In-Reply-To: <m237tqpw65.fsf@discipline.rit.edu>

On Thu, Jan 21, 2016 at 02:30:42PM -0500, Andrew W Elble wrote:
> 
> > Doesn't this mean that a compound like e.g.:
> >
> > 	PUTFH
> > 	CLOSE
> > 	OPEN
> >
> > would result in a return of true on the OPEN, if CLOSE was in must_allow
> > but OPEN wasn't?  (Because the above loop sets spo_must_allowed as soon
> > as it hits the CLOSE.)
> 
> Yes. A real-world example is DELEGRETURN with the Linux NFS client:
> 
> PUTFH
> GETATTR
> DELEGRETURN
> 
> GETATTR isn't in spo_must_allowed, but the whole compound request looks like
> krb5i in a krb5 setting. Still digesting the rest of your replies...

Ugh.  So the client actually needs to allow random other ops in any
compound containing an spo_must_allow'd operation?  That doesn't seem
right to me.

--b.

  reply	other threads:[~2016-01-21 19:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18 20:08 [PATCH v2 0/3] Deal with lost delegations and EKEYEXPIRED Andrew Elble
2016-01-18 20:08 ` [PATCH v2 1/3] nfs/nfsd: Move useful bitfield ops to a commonly accessible place Andrew Elble
2016-01-18 20:08 ` [PATCH v2 2/3] nfsd: allow mach_creds_match to be used more broadly Andrew Elble
2016-01-18 20:08 ` [PATCH v2 3/3] nfsd: implement machine credential support for some operations Andrew Elble
2016-01-20 22:53   ` J. Bruce Fields
2016-01-21 16:07     ` J. Bruce Fields
2016-01-21 19:01   ` J. Bruce Fields
2016-01-21 19:30     ` Andrew W Elble
2016-01-21 19:50       ` J. Bruce Fields [this message]
2016-01-22  0:01         ` Andrew W Elble
2016-01-22 15:24           ` J. Bruce Fields
2016-01-22 16:06             ` Trond Myklebust
2016-01-22 15:40   ` J. Bruce Fields
2016-01-22 16:09     ` Andrew W Elble
2016-01-22 16:36       ` J. Bruce Fields
2016-01-20 22:34 ` [PATCH v2 0/3] Deal with lost delegations and EKEYEXPIRED J. Bruce Fields
  -- strict thread matches above, loose matches on Subject: below --
2016-01-05 18:55 Andrew Elble
2016-01-05 18:55 ` [PATCH v2 3/3] nfsd: implement machine credential support for some operations Andrew Elble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160121195003.GD1793@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=aweits@rit.edu \
    --cc=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.