From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
dwmw2@infradead.org, kernel-janitors@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code
Date: Sat, 23 Jan 2016 00:36:34 +0000 [thread overview]
Message-ID: <20160123003634.GA16842@google.com> (raw)
In-Reply-To: <20160111135558.6ebd1165@bbrezillon>
On Mon, Jan 11, 2016 at 01:55:58PM +0100, Boris Brezillon wrote:
> On Sun, 10 Jan 2016 07:46:39 +0100
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> > The current code is the same as 'of_machine_is_compatible'.
> > So use it in order to remove a few lines of code and to be more
> > consistent with other parts of the kernel.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Your patch looks good from a functional POV, but what is this board
> detection hack doing in the NAND driver code in the first place?
>
> Let's say I didn't see that :-).
:)
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Applied to l2-mtd.git/next
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
dwmw2@infradead.org, kernel-janitors@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code
Date: Fri, 22 Jan 2016 16:36:34 -0800 [thread overview]
Message-ID: <20160123003634.GA16842@google.com> (raw)
In-Reply-To: <20160111135558.6ebd1165@bbrezillon>
On Mon, Jan 11, 2016 at 01:55:58PM +0100, Boris Brezillon wrote:
> On Sun, 10 Jan 2016 07:46:39 +0100
> Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
>
> > The current code is the same as 'of_machine_is_compatible'.
> > So use it in order to remove a few lines of code and to be more
> > consistent with other parts of the kernel.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>
> Your patch looks good from a functional POV, but what is this board
> detection hack doing in the NAND driver code in the first place?
>
> Let's say I didn't see that :-).
:)
> Reviewed-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Applied to l2-mtd.git/next
next prev parent reply other threads:[~2016-01-23 0:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 6:46 [PATCH] mtd: nand: mpc5121: use 'of_machine_is_compatible' to simplify code Christophe JAILLET
2016-01-10 6:46 ` Christophe JAILLET
2016-01-11 12:55 ` Boris Brezillon
2016-01-11 12:55 ` Boris Brezillon
2016-01-23 0:36 ` Brian Norris [this message]
2016-01-23 0:36 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123003634.GA16842@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.