All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Quentin Casasnovas <quentin.casasnovas@oracle.com>,
	Kees Cook <keescook@google.com>, Willy Tarreau <w@1wt.eu>,
	Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH 1/2] mm: do not limit VmData with RLIMIT_DATA
Date: Sat, 23 Jan 2016 10:54:15 +0300	[thread overview]
Message-ID: <20160123075415.GH2262@uranus> (raw)
In-Reply-To: <145353478067.23962.14991739413777907906.stgit@zurg>

On Sat, Jan 23, 2016 at 10:39:40AM +0300, Konstantin Khlebnikov wrote:
> This partially reverts 84638335900f ("mm: rework virtual memory accounting")
> 
> Before that commit RLIMIT_DATA have control only over size of the brk region.
> But that change have caused problems with all existing versions of valgrind
> because they set RLIMIT_DATA to zero for some reason.
> 
> More over, current check has a major flaw: RLIMIT_DATA in bytes,
> not pages. So, some problems might have slipped through testing.
> Let's revert it for now and put back in next release.
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Link: http://lkml.kernel.org/r/20151228211015.GL2194@uranus
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>

Looks great for me. Thanks a lot, Kostya!
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: linux-mm@kvack.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Vegard Nossum <vegard.nossum@oracle.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Quentin Casasnovas <quentin.casasnovas@oracle.com>,
	Kees Cook <keescook@google.com>, Willy Tarreau <w@1wt.eu>,
	Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH 1/2] mm: do not limit VmData with RLIMIT_DATA
Date: Sat, 23 Jan 2016 10:54:15 +0300	[thread overview]
Message-ID: <20160123075415.GH2262@uranus> (raw)
In-Reply-To: <145353478067.23962.14991739413777907906.stgit@zurg>

On Sat, Jan 23, 2016 at 10:39:40AM +0300, Konstantin Khlebnikov wrote:
> This partially reverts 84638335900f ("mm: rework virtual memory accounting")
> 
> Before that commit RLIMIT_DATA have control only over size of the brk region.
> But that change have caused problems with all existing versions of valgrind
> because they set RLIMIT_DATA to zero for some reason.
> 
> More over, current check has a major flaw: RLIMIT_DATA in bytes,
> not pages. So, some problems might have slipped through testing.
> Let's revert it for now and put back in next release.
> 
> Signed-off-by: Konstantin Khlebnikov <koct9i@gmail.com>
> Link: http://lkml.kernel.org/r/20151228211015.GL2194@uranus
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>

Looks great for me. Thanks a lot, Kostya!
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>

  parent reply	other threads:[~2016-01-23  7:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23  7:39 [PATCH 1/2] mm: do not limit VmData with RLIMIT_DATA Konstantin Khlebnikov
2016-01-23  7:39 ` Konstantin Khlebnikov
2016-01-23  7:39 ` [PATCH 2/2] mm: " Konstantin Khlebnikov
2016-01-23  7:39   ` Konstantin Khlebnikov
2016-01-23  7:55   ` Cyrill Gorcunov
2016-01-23  7:55     ` Cyrill Gorcunov
2016-01-23  7:54 ` Cyrill Gorcunov [this message]
2016-01-23  7:54   ` [PATCH 1/2] mm: do not " Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160123075415.GH2262@uranus \
    --to=gorcunov@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linuxfoundation.org \
    --cc=keescook@google.com \
    --cc=koct9i@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=quentin.casasnovas@oracle.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vdavydov@virtuozzo.com \
    --cc=vegard.nossum@oracle.com \
    --cc=w@1wt.eu \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.