From: Borislav Petkov <bp@alien8.de>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>,
yu-cheng yu <yu-cheng.yu@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Rik van Riel <riel@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/5] x86/fpu: Fix math emulation in eager fpu mode
Date: Sat, 23 Jan 2016 18:51:14 +0100 [thread overview]
Message-ID: <20160123175114.GE16329@pd.tnic> (raw)
In-Reply-To: <CALCETrXpGOJpdFnw1oL4HM8VT1cJt=myqHp+HiE1VD2TOF5Gyw@mail.gmail.com>
On Sat, Jan 23, 2016 at 09:40:06AM -0800, Andy Lutomirski wrote:
> I'm confused. I want to make use_eager_fpu() return true always, so
> how would this help? The idea is for FPU emulation to work despite
> being in eager mode.
I mean this:
static __always_inline __pure bool use_eager_fpu(void)
{
if (!static_cpu_has(X86_FEATURE_FPU))
return false;
return static_cpu_has(X86_FEATURE_EAGER_FPU);
}
Although now I realize that returning false is ambiguous here. F'get it.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-01-23 17:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 0:56 [PATCH 0/5] x86/fpu: eagerfpu fixes, speedups, and default enablement Andy Lutomirski
2016-01-23 0:56 ` [PATCH 1/5] x86/fpu: Fix math emulation in eager fpu mode Andy Lutomirski
2016-01-23 10:02 ` Borislav Petkov
2016-01-23 17:40 ` Andy Lutomirski
2016-01-23 17:51 ` Borislav Petkov [this message]
2016-01-23 0:56 ` [PATCH 2/5] x86/fpu: Fix FNSAVE usage in eagerfpu mode Andy Lutomirski
2016-01-23 0:56 ` [PATCH 3/5] x86/fpu: Fold fpu_copy into fpu__copy Andy Lutomirski
2016-01-23 0:56 ` [PATCH 4/5] x86/fpu: Speed up lazy FPU restores slightly Andy Lutomirski
2016-01-23 10:14 ` Borislav Petkov
2016-01-23 22:09 ` Andy Lutomirski
2016-01-23 23:35 ` Borislav Petkov
2016-01-23 0:56 ` [PATCH 5/5] x86/fpu: Default eagerfpu=on on all CPUs Andy Lutomirski
2016-01-23 10:19 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160123175114.GE16329@pd.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=yu-cheng.yu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.