Re: [Qemu-devel] [PATCH 08/13] cuda: port FILE_SERVER_FLAG command to new framework

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2160 bytes --]

On Sat, Jan 23, 2016 at 09:40:05PM +0100, Hervé Poussineau wrote:
> This command tells if computer should automatically wake-up after a power loss.
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/misc/macio/cuda.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c
> index 70a5d0c..294e8fb 100644
> --- a/hw/misc/macio/cuda.c
> +++ b/hw/misc/macio/cuda.c
> @@ -625,12 +625,28 @@ static bool cuda_cmd_reset_system(CUDAState *s,
>      return true;
>  }
>  
> +static bool cuda_cmd_set_file_server_flag(CUDAState *s,
> +                                          const uint8_t *in_data, int in_len,
> +                                          uint8_t *out_data, int *out_len)
> +{
> +    if (in_len != 1) {
> +        return false;
> +    }
> +
> +    qemu_log_mask(LOG_UNIMP,
> +                  "CUDA: unimplemented command FILE_SERVER_FLAG %d\n",
> +                  in_data[0]);
> +    return true;
> +}
> +
>  static const CudaCommand handlers[] = {
>      { CUDA_AUTOPOLL, "AUTOPOLL", cuda_cmd_autopoll },
>      { CUDA_SET_AUTO_RATE, "SET_AUTO_RATE",  cuda_cmd_set_autorate },
>      { CUDA_SET_DEVICE_LIST, "SET_DEVICE_LIST", cuda_cmd_set_device_list },
>      { CUDA_POWERDOWN, "POWERDOWN", cuda_cmd_powerdown },
>      { CUDA_RESET_SYSTEM, "RESET_SYSTEM", cuda_cmd_reset_system },
> +    { CUDA_FILE_SERVER_FLAG, "FILE_SERVER_FLAG",
> +      cuda_cmd_set_file_server_flag },
>  };
>  
>  static void cuda_receive_packet(CUDAState *s,
> @@ -678,7 +694,6 @@ static void cuda_receive_packet(CUDAState *s,
>          obuf[6] = ti;
>          cuda_send_packet_to_host(s, obuf, 7);
>          return;
> -    case CUDA_FILE_SERVER_FLAG:
>      case CUDA_SET_POWER_MESSAGES:
>          cuda_send_packet_to_host(s, obuf, 3);
>          return;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]