Re: [Qemu-devel] [PATCH 00/13] cuda: misc fixes and cleanups

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

On Sat, Jan 23, 2016 at 09:39:57PM +0100, Hervé Poussineau wrote:
> Hi,
> 
> This patchset cleans up a little bit the Apple CUDA emulation:
> - correctly reject unknown commands
> - correctly reject commands with wrong parameters
> - support changing the frequency of auto-polling
> - support changing device list probed in auto-poll
> - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE
> - remove unused commands (GET/SET_6805_ADDR)
> - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC
> 
> GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once
> we implement the I2C bus provided by CUDA.
> 
> This also fixes MacBugs hanging at startup in the absence of
> ADB mouse input.
> 
> Hervé

This series looks sound in concept, but there's a couple of things I
need before applying it:
  * On inspection I noticed a handful of small problems, noted in
    comments on the individual patches
  * I'm not really set up to test Mac, so if I can get a Tested-by
    from someone who can, that would be good (Mark?).

Thanks,
David.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]