[Xenomai] [PATCH] kernel/drivers/net/drivers/fec: fix compile-time errors

[Xenomai] [PATCH] kernel/drivers/net/drivers/fec: fix compile-time errors

[LOYAU, Florian]

As requested by Gilles, here's a patch fixing minor build issues with the
FEC RTnet driver for i.MX platforms. This doesn't alter Kconfig, so doesn't
reenable building it, since I believe you guys will want to make sure
everything works right before then.

Be aware that as i mentionned in the earlier mail, it doesn't seem to fully
work, as the device rx rtskb pool seems to run out after some time. However
we observed the same issues with different drivers, and they might just
have been fixed since then.

---
 kernel/drivers/net/drivers/fec.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/drivers/net/drivers/fec.c
b/kernel/drivers/net/drivers/fec.c
index 290b765..753dab7 100644
--- a/kernel/drivers/net/drivers/fec.c
+++ b/kernel/drivers/net/drivers/fec.c
@@ -1047,7 +1047,7 @@ static int fec_enet_mii_probe(struct rtnet_device
*ndev)

        snprintf(phy_name, sizeof(phy_name), PHY_ID_FMT, mdio_bus_id,
phy_id);
        /* attach the mac to the phy using the dummy linux netdev */
-       phy_dev = phy_connect(fep->netdev, phy_name, &fec_enet_adjust_link,
0,
+       phy_dev = phy_connect(fep->netdev, phy_name, &fec_enet_adjust_link,
/* 0, */
                              fep->phy_interface);
        if (IS_ERR(phy_dev)) {
                printk(KERN_ERR "%s: could not attach to PHY\n",
ndev->name);
@@ -1266,7 +1266,7 @@ static int fec_enet_alloc_buffers(struct rtnet_device
*ndev)

        bdp = fep->rx_bd_base;
        for (i = 0; i < RX_RING_SIZE; i++) {
-               skb = rtnetdev_alloc_rtskb(netdev, FEC_ENET_RX_FRSIZE); /*
RTnet */
+               skb = rtnetdev_alloc_rtskb(ndev, FEC_ENET_RX_FRSIZE); /*
RTnet */
                if (!skb) {
                        fec_enet_free_buffers(ndev);
                        return -ENOMEM;
--
1.7.10.4

Re: [Xenomai] [PATCH] kernel/drivers/net/drivers/fec: fix compile-time errors

[Gilles Chanteperdrix]

On Mon, Jan 25, 2016 at 08:50:39AM +0100, LOYAU, Florian wrote:
> As requested by Gilles, here's a patch fixing minor build issues with the
> FEC RTnet driver for i.MX platforms. This doesn't alter Kconfig, so doesn't
> reenable building it, since I believe you guys will want to make sure
> everything works right before then.

Your MUA broke the patch, and the patch adds dead code. Also, for
what version of Linux did you modify the driver? 3.10, 3.14, 3.18 or
4.1? All versions?


> 
> Be aware that as i mentionned in the earlier mail, it doesn't seem to fully
> work, as the device rx rtskb pool seems to run out after some time. However
> we observed the same issues with different drivers, and they might just
> have been fixed since then.

Well, no. loopback has been fixed in the current stable and next
branches of xenomai 3 repository, but no other driver needed fixing
as far as I can tell. Also, a testsuite for RTnet UDP, raw packet
and "cooked" packet was added recently, you can use it to check if
all the drivers you need are working. To use it you will need to
enable rtcfg, run the program named "smokey_net_server" on one
machine, and smokey on the tested machine, for instance using the
UDP test. Use the rtnet_driver, rtnet_interface, rtnet_rate
and rtnet_duration parameters to specify the test parameters.

-- 
					    Gilles.
https://click-hack.org