All of lore.kernel.org
 help / color / mirror / Atom feed
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: kernel: fix architected PMU registers unconditional access
Date: Mon, 25 Jan 2016 09:36:05 +0000	[thread overview]
Message-ID: <20160125093604.GA32652@red-moon> (raw)
In-Reply-To: <56A2E2CD.80904@roeck-us.net>

Hi Guenter,

On Fri, Jan 22, 2016 at 06:17:49PM -0800, Guenter Roeck wrote:
> On 01/13/2016 06:50 AM, Lorenzo Pieralisi wrote:
> >The Performance Monitors extension is an optional feature of the
> >AArch64 architecture, therefore, in order to access Performance
> >Monitors registers safely, the kernel should detect the architected
> >PMU unit presence through the ID_AA64DFR0_EL1 register PMUVer field
> >before accessing them.
> >
> >This patch implements a guard by reading the ID_AA64DFR0_EL1 register
> >PMUVer field to detect the architected PMU presence and prevent accessing
> >PMU system registers if the Performance Monitors extension is not
> >implemented in the core.
> >
> >Fixes: 60792ad349f3 ("arm64: kernel: enforce pmuserenr_el0 initialization and restore")
> >Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >Reported-by: Guenter Roeck <linux@roeck-us.net>
> >Tested-by: Guenter Roeck <linux@roeck-us.net>
> >Cc: Will Deacon <will.deacon@arm.com>
> >Cc: Peter Maydell <peter.maydell@linaro.org>
> >Cc: Mark Rutland <mark.rutland@arm.com>
> 
> Hi,
> 
> this patch is still missing in mainline.
> 
> Did it get lost ?

No it did not, it will be sent shortly, thanks.

Lorenzo

WARNING: multiple messages have this Message-ID (diff)
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Will Deacon <will.deacon@arm.com>,
	qemu-devel@nongnu.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [Qemu-devel] [PATCH v2] arm64: kernel: fix architected PMU registers unconditional access
Date: Mon, 25 Jan 2016 09:36:05 +0000	[thread overview]
Message-ID: <20160125093604.GA32652@red-moon> (raw)
In-Reply-To: <56A2E2CD.80904@roeck-us.net>

Hi Guenter,

On Fri, Jan 22, 2016 at 06:17:49PM -0800, Guenter Roeck wrote:
> On 01/13/2016 06:50 AM, Lorenzo Pieralisi wrote:
> >The Performance Monitors extension is an optional feature of the
> >AArch64 architecture, therefore, in order to access Performance
> >Monitors registers safely, the kernel should detect the architected
> >PMU unit presence through the ID_AA64DFR0_EL1 register PMUVer field
> >before accessing them.
> >
> >This patch implements a guard by reading the ID_AA64DFR0_EL1 register
> >PMUVer field to detect the architected PMU presence and prevent accessing
> >PMU system registers if the Performance Monitors extension is not
> >implemented in the core.
> >
> >Fixes: 60792ad349f3 ("arm64: kernel: enforce pmuserenr_el0 initialization and restore")
> >Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> >Reported-by: Guenter Roeck <linux@roeck-us.net>
> >Tested-by: Guenter Roeck <linux@roeck-us.net>
> >Cc: Will Deacon <will.deacon@arm.com>
> >Cc: Peter Maydell <peter.maydell@linaro.org>
> >Cc: Mark Rutland <mark.rutland@arm.com>
> 
> Hi,
> 
> this patch is still missing in mainline.
> 
> Did it get lost ?

No it did not, it will be sent shortly, thanks.

Lorenzo

  reply	other threads:[~2016-01-25  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13 14:50 [PATCH v2] arm64: kernel: fix architected PMU registers unconditional access Lorenzo Pieralisi
2016-01-13 14:50 ` [Qemu-devel] " Lorenzo Pieralisi
2016-01-23  2:17 ` Guenter Roeck
2016-01-23  2:17   ` [Qemu-devel] " Guenter Roeck
2016-01-25  9:36   ` Lorenzo Pieralisi [this message]
2016-01-25  9:36     ` Lorenzo Pieralisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160125093604.GA32652@red-moon \
    --to=lorenzo.pieralisi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.