From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heikki Krogerus
<heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Marc Dietrich <marvin24-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio
Date: Mon, 25 Jan 2016 13:18:40 +0100 [thread overview]
Message-ID: <20160125121840.GA20452@ulmo.nvidia.com> (raw)
In-Reply-To: <1453712629-143317-4-git-send-email-heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Mon, Jan 25, 2016 at 12:03:48PM +0300, Heikki Krogerus wrote:
> Pass the rfkill name and type to the device with properties
> instead of driver specific platform data.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> CC: Alexandre Courbot <gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> CC: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> CC: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
> ---
> arch/arm/mach-tegra/board-paz00.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Looks fine to me. We might want to wait for Marc (Cc'ed) to give this a
spin, since I don't have the hardware. For reference, the series can be
found here:
http://patchwork.ozlabs.org/patch/572640/
http://patchwork.ozlabs.org/patch/572644/
http://patchwork.ozlabs.org/patch/572643/
http://patchwork.ozlabs.org/patch/572642/
Johannes, I assume that you'll want to take this through your tree
because of the dependency? In that case:
Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
Alexandre Courbot <gnurou@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Marc Dietrich <marvin24@gmx.de>
Subject: Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio
Date: Mon, 25 Jan 2016 13:18:40 +0100 [thread overview]
Message-ID: <20160125121840.GA20452@ulmo.nvidia.com> (raw)
In-Reply-To: <1453712629-143317-4-git-send-email-heikki.krogerus@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Mon, Jan 25, 2016 at 12:03:48PM +0300, Heikki Krogerus wrote:
> Pass the rfkill name and type to the device with properties
> instead of driver specific platform data.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> CC: Alexandre Courbot <gnurou@gmail.com>
> CC: Thierry Reding <thierry.reding@gmail.com>
> CC: Stephen Warren <swarren@wwwdotorg.org>
> ---
> arch/arm/mach-tegra/board-paz00.c | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
Looks fine to me. We might want to wait for Marc (Cc'ed) to give this a
spin, since I don't have the hardware. For reference, the series can be
found here:
http://patchwork.ozlabs.org/patch/572640/
http://patchwork.ozlabs.org/patch/572644/
http://patchwork.ozlabs.org/patch/572643/
http://patchwork.ozlabs.org/patch/572642/
Johannes, I assume that you'll want to take this through your tree
because of the dependency? In that case:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-25 12:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 9:03 [PATCHv2 0/4] net: rfkill: gpio: replace platform data with build-in property Heikki Krogerus
2016-01-25 9:03 ` Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 1/4] net: rfkill: add rfkill_find_type function Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 2/4] net: rfkill: gpio: get the name and type from device property Heikki Krogerus
2016-01-25 9:03 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Heikki Krogerus
[not found] ` <1453712629-143317-4-git-send-email-heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-25 12:18 ` Thierry Reding [this message]
2016-01-25 12:18 ` Thierry Reding
[not found] ` <20160125121840.GA20452-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2016-01-25 20:59 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties withrfkill_gpio Marc Dietrich
2016-01-25 20:59 ` Marc Dietrich
2016-01-26 8:46 ` Johannes Berg
[not found] ` <1453798016.2759.5.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-01-26 8:52 ` [PATCHv2 3/4] ARM: tegra: use build-in device propertieswithrfkill_gpio Marc Dietrich
2016-01-26 8:52 ` Marc Dietrich
2016-01-26 8:42 ` [PATCHv2 3/4] ARM: tegra: use build-in device properties with rfkill_gpio Johannes Berg
2016-01-26 8:42 ` Johannes Berg
2016-02-18 20:04 ` Johannes Berg
[not found] ` <1455825889.2084.16.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2016-02-19 18:03 ` Thierry Reding
2016-02-19 18:03 ` Thierry Reding
2016-02-23 10:31 ` Johannes Berg
2016-02-23 10:15 ` Arnd Bergmann
2016-02-23 10:15 ` Arnd Bergmann
2016-02-23 10:31 ` Arnd Bergmann
2016-02-23 10:38 ` Marc Dietrich
2016-02-23 13:17 ` Arnd Bergmann
2016-02-23 13:42 ` Marc Dietrich
2016-02-23 15:06 ` Arnd Bergmann
2016-02-23 20:39 ` Johannes Berg
2016-01-25 9:03 ` [PATCHv2 4/4] net: rfkill: gpio: remove rfkill_gpio_platform_data Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125121840.GA20452@ulmo.nvidia.com \
--to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marvin24-Mmb7MZpHnFY@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.