All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: ptyser@xes-inc.com, linus.walleij@linaro.org, gnurou@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] gpio: gpio-ich: add support for Intel Baytrail
Date: Mon, 25 Jan 2016 12:43:59 +0000	[thread overview]
Message-ID: <20160125124359.GI3368@x1> (raw)
In-Reply-To: <1453566729-30220-2-git-send-email-antoine.tenart@free-electrons.com>

On Sat, 23 Jan 2016, Antoine Tenart wrote:

> This patch adds support for the Braytrail series, with the hardware
> blink capability.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  drivers/gpio/gpio-ich.c     | 12 ++++++++++++
>  include/linux/mfd/lpc_ich.h |  1 +

Acked-by: Lee Jones <lee.jones@linaro.org>

>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index 4ba7ed502131..6f5fcae32855 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -384,6 +384,15 @@ static struct ichx_desc avoton_desc = {
>  	.use_outlvl_cache = true,
>  };
>  
> +/* Baytrail */
> +static struct ichx_desc baytrail_desc = {
> +	.ngpio = 96,
> +	.regs = ichx_regs,
> +	.reglen = ichx_reglen,
> +	.have_blink = true,
> +	.use_outlvl_cache = true,
> +};
> +
>  static int ichx_gpio_request_regions(struct resource *res_base,
>  						const char *name, u8 use_gpio)
>  {
> @@ -461,6 +470,9 @@ static int ichx_gpio_probe(struct platform_device *pdev)
>  	case AVOTON_GPIO:
>  		ichx_priv.desc = &avoton_desc;
>  		break;
> +	case ICH_BAYTRAIL_GPIO:
> +		ichx_priv.desc = &baytrail_desc;
> +		break;
>  	default:
>  		return -ENODEV;
>  	}
> diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> index 2b300b44f994..659a1cd875d8 100644
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -34,6 +34,7 @@ enum {
>  	ICH_V10CORP_GPIO,
>  	ICH_V10CONS_GPIO,
>  	AVOTON_GPIO,
> +	ICH_BAYTRAIL_GPIO,
>  };
>  
>  struct lpc_ich_info {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: ptyser@xes-inc.com, linus.walleij@linaro.org, gnurou@gmail.com,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] gpio: gpio-ich: add support for Intel Baytrail
Date: Mon, 25 Jan 2016 12:43:59 +0000	[thread overview]
Message-ID: <20160125124359.GI3368@x1> (raw)
In-Reply-To: <1453566729-30220-2-git-send-email-antoine.tenart@free-electrons.com>

On Sat, 23 Jan 2016, Antoine Tenart wrote:

> This patch adds support for the Braytrail series, with the hardware
> blink capability.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  drivers/gpio/gpio-ich.c     | 12 ++++++++++++
>  include/linux/mfd/lpc_ich.h |  1 +

Acked-by: Lee Jones <lee.jones@linaro.org>

>  2 files changed, 13 insertions(+)
> 
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index 4ba7ed502131..6f5fcae32855 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -384,6 +384,15 @@ static struct ichx_desc avoton_desc = {
>  	.use_outlvl_cache = true,
>  };
>  
> +/* Baytrail */
> +static struct ichx_desc baytrail_desc = {
> +	.ngpio = 96,
> +	.regs = ichx_regs,
> +	.reglen = ichx_reglen,
> +	.have_blink = true,
> +	.use_outlvl_cache = true,
> +};
> +
>  static int ichx_gpio_request_regions(struct resource *res_base,
>  						const char *name, u8 use_gpio)
>  {
> @@ -461,6 +470,9 @@ static int ichx_gpio_probe(struct platform_device *pdev)
>  	case AVOTON_GPIO:
>  		ichx_priv.desc = &avoton_desc;
>  		break;
> +	case ICH_BAYTRAIL_GPIO:
> +		ichx_priv.desc = &baytrail_desc;
> +		break;
>  	default:
>  		return -ENODEV;
>  	}
> diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> index 2b300b44f994..659a1cd875d8 100644
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -34,6 +34,7 @@ enum {
>  	ICH_V10CORP_GPIO,
>  	ICH_V10CONS_GPIO,
>  	AVOTON_GPIO,
> +	ICH_BAYTRAIL_GPIO,
>  };
>  
>  struct lpc_ich_info {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2016-01-25 12:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-23 16:32 [PATCH 0/3] gpio: Intel Baytrail support Antoine Tenart
2016-01-23 16:32 ` [PATCH 1/3] gpio: gpio-ich: add support for Intel Baytrail Antoine Tenart
2016-01-25 12:43   ` Lee Jones [this message]
2016-01-25 12:43     ` Lee Jones
2016-01-23 16:32 ` [PATCH 2/3] mfd: lpc_ich: use a correct mask for the GPIO base address Antoine Tenart
2016-01-25 12:44   ` Lee Jones
2016-01-25 16:07     ` Peter Tyser
2016-02-11 17:12       ` Lee Jones
2016-02-11 17:12         ` Lee Jones
2016-01-23 16:32 ` [PATCH 3/3] mfd: lpc_ich: add GPIO support for Baytrail Antoine Tenart
2016-01-25 12:45   ` Lee Jones
2016-01-25 12:45     ` Lee Jones
2016-01-28 10:34   ` Linus Walleij
2016-01-28 15:48     ` Mika Westerberg
2016-01-25 11:49 ` [PATCH 0/3] gpio: Intel Baytrail support Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160125124359.GI3368@x1 \
    --to=lee.jones@linaro.org \
    --cc=antoine.tenart@free-electrons.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ptyser@xes-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.