From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Colin King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/sysfs: remove unused va_list args
Date: Mon, 25 Jan 2016 13:28:23 -0500 [thread overview]
Message-ID: <20160125182822.GA18364@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/core/sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> union ib_gid gid;
> struct ib_gid_attr gid_attr = {};
> ssize_t ret;
> - va_list args;
>
> ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
> &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> err:
> if (gid_attr.ndev)
> dev_put(gid_attr.ndev);
> - va_end(args);
> return ret;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "ira.weiny" <ira.weiny@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Christoph Lameter <cl@linux.com>,
Matan Barak <matanb@mellanox.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/sysfs: remove unused va_list args
Date: Mon, 25 Jan 2016 13:28:23 -0500 [thread overview]
Message-ID: <20160125182822.GA18364@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <1453742627-24698-1-git-send-email-colin.king@canonical.com>
On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/infiniband/core/sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> union ib_gid gid;
> struct ib_gid_attr gid_attr = {};
> ssize_t ret;
> - va_list args;
>
> ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
> &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> err:
> if (gid_attr.ndev)
> dev_put(gid_attr.ndev);
> - va_end(args);
> return ret;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-25 18:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 17:23 [PATCH] IB/sysfs: remove unused va_list args Colin King
2016-01-25 17:23 ` Colin King
[not found] ` <1453742627-24698-1-git-send-email-colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2016-01-25 17:47 ` Jason Gunthorpe
2016-01-25 17:47 ` Jason Gunthorpe
2016-01-25 18:28 ` ira.weiny [this message]
2016-01-25 18:28 ` ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125182822.GA18364@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.