From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static
Date: Tue, 26 Jan 2016 15:51:16 -0300 [thread overview]
Message-ID: <20160126185116.GA11676@kernel.org> (raw)
In-Reply-To: <CANLsYkwbBCwT0B4NV0pGo+avyyX9kiPzYZK5WtmfHaqnW8Q6uA@mail.gmail.com>
Em Tue, Jan 26, 2016 at 10:08:21AM -0700, Mathieu Poirier escreveu:
> On 25 January 2016 at 14:29, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Mon, Jan 25, 2016 at 06:12:42PM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Mon, Jan 25, 2016 at 01:46:22PM -0700, Mathieu Poirier escreveu:
> >> > On 14 January 2016 at 14:46, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >> > I can't queue this patch for 4.6 without at least a reviewed by from you.
> >>
> >> This one I remember, looks ugly, the name set_max_cpu_num() looks
> >> strange, when that was restricted (static) to that cpumap.c file, it
> >> wasn't a problem, exporting it for wider usage looks bad.
> >>
> >> You've been waiting for this for quite a while, it seems, lemme stop
> >> what I am doing to check this...
> >
> > So, please check the patch below, what you need then is just to use
> > cpu__max_cpu().
>
> I like your approach - thanks for the review. I will spin V9 when I
> have received Adrian's comments.
I'll take that as an Acked-by: and since this improves the current
situation by hiding needlessly exported global variables, I'll get it in
now, thanks.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: linux-doc@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static
Date: Tue, 26 Jan 2016 15:51:16 -0300 [thread overview]
Message-ID: <20160126185116.GA11676@kernel.org> (raw)
In-Reply-To: <CANLsYkwbBCwT0B4NV0pGo+avyyX9kiPzYZK5WtmfHaqnW8Q6uA@mail.gmail.com>
Em Tue, Jan 26, 2016 at 10:08:21AM -0700, Mathieu Poirier escreveu:
> On 25 January 2016 at 14:29, Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Mon, Jan 25, 2016 at 06:12:42PM -0300, Arnaldo Carvalho de Melo escreveu:
> >> Em Mon, Jan 25, 2016 at 01:46:22PM -0700, Mathieu Poirier escreveu:
> >> > On 14 January 2016 at 14:46, Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >> > I can't queue this patch for 4.6 without at least a reviewed by from you.
> >>
> >> This one I remember, looks ugly, the name set_max_cpu_num() looks
> >> strange, when that was restricted (static) to that cpumap.c file, it
> >> wasn't a problem, exporting it for wider usage looks bad.
> >>
> >> You've been waiting for this for quite a while, it seems, lemme stop
> >> what I am doing to check this...
> >
> > So, please check the patch below, what you need then is just to use
> > cpu__max_cpu().
>
> I like your approach - thanks for the review. I will spin V9 when I
> have received Adrian's comments.
I'll take that as an Acked-by: and since this improves the current
situation by hiding needlessly exported global variables, I'll get it in
now, thanks.
- Arnaldo
next prev parent reply other threads:[~2016-01-26 18:51 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 21:45 [PATCH V8 00/23] Coresight integration with perf Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:45 ` [PATCH V8 01/23] coresight: associating path with session rather than tracer Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:45 ` [PATCH V8 02/23] coresight: add API to get sink from path Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:45 ` [PATCH V8 03/23] coresight: moving PM runtime operations to core framework Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:45 ` [PATCH V8 04/23] coresight: etm3x: moving etm_readl/writel to header file Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:45 ` [PATCH V8 05/23] coresight: etm3x: moving sysFS entries to dedicated file Mathieu Poirier
2016-01-14 21:45 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 06/23] coresight: etm3x: unlocking tracers in default arch init Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 07/23] coresight: etm3x: splitting struct etm_drvdata Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 08/23] coresight: etm3x: adding operation mode for etm_enable() Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 09/23] coresight: etm3x: set progbit to stop trace collection Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 10/23] coresight: etm3x: changing default trace configuration Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 11/23] coresight: etm3x: consolidating initial config Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 12/23] coresight: etm3x: implementing user/kernel mode tracing Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 13/23] coresight: etm3x: implementing perf_enable/disable() API Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 14/23] coresight: etb10: moving to local atomic operations Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 15/23] coresight: etb10: adding operation mode for sink->enable() Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 16/23] coresight: etb10: implementing AUX API Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-26 15:53 ` Alexander Shishkin
2016-01-26 15:53 ` Alexander Shishkin
2016-01-27 20:55 ` Mathieu Poirier
2016-01-27 20:55 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 17/23] coresight: updating documentation to reflect integration with perf Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 18/23] coresight: etm-perf: new PMU driver for ETM tracers Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-26 15:27 ` Alexander Shishkin
2016-01-26 15:27 ` Alexander Shishkin
2016-01-27 18:33 ` Mathieu Poirier
2016-01-27 18:33 ` Mathieu Poirier
2016-01-28 15:42 ` Alexander Shishkin
2016-01-28 15:42 ` Alexander Shishkin
2016-01-28 21:12 ` Mathieu Poirier
2016-01-28 21:12 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 19/23] coresight: introducing a global trace ID function Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 20/23] perf tools: making function set_max_cpu_num() non static Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-25 20:46 ` Mathieu Poirier
2016-01-25 20:46 ` Mathieu Poirier
2016-01-25 21:12 ` Arnaldo Carvalho de Melo
2016-01-25 21:12 ` Arnaldo Carvalho de Melo
2016-01-25 21:29 ` Arnaldo Carvalho de Melo
2016-01-25 21:29 ` Arnaldo Carvalho de Melo
2016-01-26 17:08 ` Mathieu Poirier
2016-01-26 17:08 ` Mathieu Poirier
2016-01-26 18:51 ` Arnaldo Carvalho de Melo [this message]
2016-01-26 18:51 ` Arnaldo Carvalho de Melo
2016-01-27 16:24 ` Mathieu Poirier
2016-01-27 16:24 ` Mathieu Poirier
2016-02-03 10:15 ` [tip:perf/core] perf cpumap: Auto initialize cpu__max_{node,cpu} tip-bot for Arnaldo Carvalho de Melo
2016-01-14 21:46 ` [PATCH V8 21/23] perf tools: adding perf_evlist to *info_priv_size() Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-25 20:48 ` Mathieu Poirier
2016-01-25 20:48 ` Mathieu Poirier
2016-01-25 21:08 ` Arnaldo Carvalho de Melo
2016-01-25 21:08 ` Arnaldo Carvalho de Melo
2016-01-26 14:27 ` Adrian Hunter
2016-01-26 14:27 ` Adrian Hunter
2016-01-26 14:33 ` Arnaldo Carvalho de Melo
2016-01-26 14:33 ` Arnaldo Carvalho de Melo
2016-01-29 10:14 ` Adrian Hunter
2016-01-29 10:14 ` Adrian Hunter
2016-02-03 10:17 ` [tip:perf/core] perf auxtrace: Add perf_evlist pointer " tip-bot for Mathieu Poirier
2016-01-14 21:46 ` [PATCH V8 22/23] perf tools: making coresight PMU listable Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-25 20:49 ` Mathieu Poirier
2016-01-25 20:49 ` Mathieu Poirier
2016-01-25 21:10 ` Arnaldo Carvalho de Melo
2016-01-25 21:10 ` Arnaldo Carvalho de Melo
2016-01-29 10:24 ` Adrian Hunter
2016-01-29 10:24 ` Adrian Hunter
2016-01-14 21:46 ` [PATCH V8 23/23] perf tools: adding coresight etm PMU record capabilities Mathieu Poirier
2016-01-14 21:46 ` Mathieu Poirier
2016-01-25 20:51 ` Mathieu Poirier
2016-01-25 20:51 ` Mathieu Poirier
2016-01-25 21:10 ` Arnaldo Carvalho de Melo
2016-01-25 21:10 ` Arnaldo Carvalho de Melo
2016-01-29 10:34 ` Adrian Hunter
2016-01-29 10:34 ` Adrian Hunter
2016-01-29 17:37 ` Mathieu Poirier
2016-01-29 17:37 ` Mathieu Poirier
2016-01-29 21:12 ` Arnaldo Carvalho de Melo
2016-01-29 21:12 ` Arnaldo Carvalho de Melo
2016-01-29 22:24 ` Mathieu Poirier
2016-01-29 22:24 ` Mathieu Poirier
2016-02-02 16:20 ` Mathieu Poirier
2016-02-02 16:20 ` Mathieu Poirier
2016-02-02 16:41 ` Arnaldo Carvalho de Melo
2016-02-02 16:41 ` Arnaldo Carvalho de Melo
2016-02-03 16:11 ` Mathieu Poirier
2016-02-03 16:11 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126185116.GA11676@kernel.org \
--to=acme@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.