From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Doug Gilbert <dgilbert@interlog.com>,
David Rientjes <rientjes@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Shiraz Hashim <shashim@codeaurora.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
linux-scsi@vger.kernel.org
Subject: Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind
Date: Tue, 26 Jan 2016 23:05:34 +0200 [thread overview]
Message-ID: <20160126210534.GA22852@node.shutemov.name> (raw)
In-Reply-To: <20160126124916.1f4ed291a6e4bcf19b74b7f7@linux-foundation.org>
On Tue, Jan 26, 2016 at 12:49:16PM -0800, Andrew Morton wrote:
> On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
> > Let's mark the VMA as VM_IO to indicate to mm core that the VMA is
> > migratable.
> >
> > ...
> >
> > --- a/drivers/scsi/sg.c
> > +++ b/drivers/scsi/sg.c
> > @@ -1261,7 +1261,7 @@ sg_mmap(struct file *filp, struct vm_area_struct *vma)
> > }
> >
> > sfp->mmap_called = 1;
> > - vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
> > + vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP;
> > vma->vm_private_data = sfp;
> > vma->vm_ops = &sg_mmap_vm_ops;
> > return 0;
>
> I'll put cc:stable on this - I don't think we recently did anything to make
> this happen?
The VM_BUG_ON is new bb5b8589767a ("mm: make sure isolate_lru_page() is
never called for tail page"), but I don't think it changes the picture
much.
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Doug Gilbert <dgilbert@interlog.com>,
David Rientjes <rientjes@google.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Shiraz Hashim <shashim@codeaurora.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
linux-scsi@vger.kernel.org
Subject: Re: mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind
Date: Tue, 26 Jan 2016 23:05:34 +0200 [thread overview]
Message-ID: <20160126210534.GA22852@node.shutemov.name> (raw)
In-Reply-To: <20160126124916.1f4ed291a6e4bcf19b74b7f7@linux-foundation.org>
On Tue, Jan 26, 2016 at 12:49:16PM -0800, Andrew Morton wrote:
> On Tue, 26 Jan 2016 22:28:29 +0200 "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
> > Let's mark the VMA as VM_IO to indicate to mm core that the VMA is
> > migratable.
> >
> > ...
> >
> > --- a/drivers/scsi/sg.c
> > +++ b/drivers/scsi/sg.c
> > @@ -1261,7 +1261,7 @@ sg_mmap(struct file *filp, struct vm_area_struct *vma)
> > }
> >
> > sfp->mmap_called = 1;
> > - vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
> > + vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP;
> > vma->vm_private_data = sfp;
> > vma->vm_ops = &sg_mmap_vm_ops;
> > return 0;
>
> I'll put cc:stable on this - I don't think we recently did anything to make
> this happen?
The VM_BUG_ON is new bb5b8589767a ("mm: make sure isolate_lru_page() is
never called for tail page"), but I don't think it changes the picture
much.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2016-01-26 21:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 12:52 mm: VM_BUG_ON_PAGE(PageTail(page)) in mbind Dmitry Vyukov
2016-01-26 12:52 ` Dmitry Vyukov
2016-01-26 20:28 ` Kirill A. Shutemov
2016-01-26 20:28 ` Kirill A. Shutemov
2016-01-26 20:28 ` Kirill A. Shutemov
2016-01-26 20:48 ` Andrew Morton
2016-01-26 20:48 ` Andrew Morton
2016-01-26 21:07 ` Kirill A. Shutemov
2016-01-26 21:07 ` Kirill A. Shutemov
2016-01-26 20:49 ` Andrew Morton
2016-01-26 20:49 ` Andrew Morton
2016-01-26 21:05 ` Kirill A. Shutemov [this message]
2016-01-26 21:05 ` Kirill A. Shutemov
2016-01-26 21:37 ` Vlastimil Babka
2016-01-26 21:37 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160126210534.GA22852@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=dgilbert@interlog.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hughd@google.com \
--cc=kcc@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=shashim@codeaurora.org \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.