From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Vishnu Patekar <vishnupatekar0510@gmail.com>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors parameters into a struct
Date: Wed, 27 Jan 2016 18:29:55 +0100 [thread overview]
Message-ID: <20160127172955.GK4317@lukather> (raw)
In-Reply-To: <1453727747-23307-7-git-send-email-wens@csie.org>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
On Mon, Jan 25, 2016 at 09:15:42PM +0800, Chen-Yu Tsai wrote:
> The .get_factors callback of factors_clk has 6 parameters. To extend
> factors_clk in any way that requires adding parameters to .get_factors
> would make that list even longer, not to mention changing all the
> function declarations.
>
> Do this once now and consolidate all the parameters into a struct.
> Also drop the space before function pointer arguments, since checkpatch
> complains.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors parameters into a struct
Date: Wed, 27 Jan 2016 18:29:55 +0100 [thread overview]
Message-ID: <20160127172955.GK4317@lukather> (raw)
In-Reply-To: <1453727747-23307-7-git-send-email-wens@csie.org>
On Mon, Jan 25, 2016 at 09:15:42PM +0800, Chen-Yu Tsai wrote:
> The .get_factors callback of factors_clk has 6 parameters. To extend
> factors_clk in any way that requires adding parameters to .get_factors
> would make that list even longer, not to mention changing all the
> function declarations.
>
> Do this once now and consolidate all the parameters into a struct.
> Also drop the space before function pointer arguments, since checkpatch
> complains.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/08905639/attachment.sig>
next prev parent reply other threads:[~2016-01-27 17:29 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 13:15 [PATCH RFC 00/11] clk: sunxi: factors clk clean up and refactor Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-25 13:15 ` [PATCH RFC 01/11] clk: composite: Add unregister function Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-25 13:15 ` [PATCH RFC 02/11] clk: sunxi: factors: Make struct clk_factors_config table const Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 15:50 ` Maxime Ripard
2016-01-27 15:50 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 03/11] clk: sunxi: factors: Add clk cleanup in sunxi_factors_register() error path Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 15:51 ` Maxime Ripard
2016-01-27 15:51 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 04/11] clk: sunxi: factors: Add unregister function Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 15:52 ` Maxime Ripard
2016-01-27 15:52 ` Maxime Ripard
2016-01-27 18:08 ` Maxime Ripard
2016-01-27 18:08 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 05/11] clk: sunxi: unmap registers in sunxi_factors_clk_setup if register call fails Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 15:52 ` Maxime Ripard
2016-01-27 15:52 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors parameters into a struct Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:29 ` Maxime Ripard [this message]
2016-01-27 17:29 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 07/11] clk: sunxi: factors: Support custom formulas Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:32 ` Maxime Ripard
2016-01-27 17:32 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 08/11] clk: sunxi: factors: Drop round_rate from clk ops Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:33 ` Maxime Ripard
2016-01-27 17:33 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 09/11] clk: sunxi: rewrite sun6i-a31-ahb1-clk using factors clk with custom recalc Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:41 ` Maxime Ripard
2016-01-27 17:41 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 10/11] clk: sunxi: rewrite sun6i-ar100 using factors clk Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:47 ` Maxime Ripard
2016-01-27 17:47 ` Maxime Ripard
2016-01-31 16:59 ` Paul Gortmaker
2016-01-31 16:59 ` Paul Gortmaker
2016-02-05 13:03 ` Chen-Yu Tsai
2016-02-05 13:03 ` Chen-Yu Tsai
2016-02-02 15:55 ` [PATCH] clk: sunxi: don't mark sun6i_ar100_data __initconst Arnd Bergmann
2016-02-02 15:55 ` Arnd Bergmann
2016-02-02 17:33 ` Maxime Ripard
2016-02-02 17:33 ` Maxime Ripard
2016-01-25 13:15 ` [PATCH RFC 11/11] clk: sunxi: rewrite sun8i-a23-mbus-clk using the simpler composite clk Chen-Yu Tsai
2016-01-25 13:15 ` Chen-Yu Tsai
2016-01-27 17:49 ` Maxime Ripard
2016-01-27 17:49 ` Maxime Ripard
2016-01-28 2:41 ` Chen-Yu Tsai
2016-01-28 2:41 ` Chen-Yu Tsai
2016-02-01 20:24 ` Maxime Ripard
2016-02-01 20:24 ` Maxime Ripard
2016-01-27 19:13 ` [PATCH RFC 00/11] clk: sunxi: factors clk clean up and refactor Maxime Ripard
2016-01-27 19:13 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127172955.GK4317@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.