From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] ARM: dts: sun7i: Add dts file for the lamobo-r1 board
Date: Wed, 27 Jan 2016 20:47:35 +0100 [thread overview]
Message-ID: <20160127194735.GT4317@lukather> (raw)
In-Reply-To: <1453920105-7093-2-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Wed, Jan 27, 2016 at 07:41:45PM +0100, Hans de Goede wrote:
> From: Jelle de Jong <jelledejong@powercraft.nl>
>
> The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such
> on the PCB, is meant as a A20 based router board. As such the board comes
> with a built-in switch chip giving it 5 gigabit ethernet boards, and it
> has a large empty area on the pcb with mounting holes which will fit a
> 2.5 inch harddisk. To complete its networking features it has a
> Realtek RTL8192CU for WiFi 802.11 b/g/n.
>
> Signed-off-by: Jelle de Jong <jelledejong@powercraft.nl>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Sorry that I missed it :/
It looks mostly fine, I just have a minor question / comment below.
> +&cpu0 {
> + cpu-supply = <®_dcdc2>;
> + operating-points = <
> + /* kHz uV */
> + 960000 1400000
> + 912000 1400000
> + 864000 1350000
> + 720000 1250000
> + 528000 1150000
> + 312000 1100000
> + 144000 1050000
> + >;
> +};
Have you used the default OPPs and it turned out to be unstable, or is
it just some copy / paste from the FEX file?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160127/58caa72b/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Jelle de Jong
<jelledejong-OIcJOM8/mISwoUgIn9SVlA@public.gmane.org>
Subject: Re: [PATCH resend] ARM: dts: sun7i: Add dts file for the lamobo-r1 board
Date: Wed, 27 Jan 2016 20:47:35 +0100 [thread overview]
Message-ID: <20160127194735.GT4317@lukather> (raw)
In-Reply-To: <1453920105-7093-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
Hi Hans,
On Wed, Jan 27, 2016 at 07:41:45PM +0100, Hans de Goede wrote:
> From: Jelle de Jong <jelledejong-OIcJOM8/mISwoUgIn9SVlA@public.gmane.org>
>
> The lamobo-r1 board, sometimes called the BPI-R1 but not labelled as such
> on the PCB, is meant as a A20 based router board. As such the board comes
> with a built-in switch chip giving it 5 gigabit ethernet boards, and it
> has a large empty area on the pcb with mounting holes which will fit a
> 2.5 inch harddisk. To complete its networking features it has a
> Realtek RTL8192CU for WiFi 802.11 b/g/n.
>
> Signed-off-by: Jelle de Jong <jelledejong-OIcJOM8/mISwoUgIn9SVlA@public.gmane.org>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Sorry that I missed it :/
It looks mostly fine, I just have a minor question / comment below.
> +&cpu0 {
> + cpu-supply = <®_dcdc2>;
> + operating-points = <
> + /* kHz uV */
> + 960000 1400000
> + 912000 1400000
> + 864000 1350000
> + 720000 1250000
> + 528000 1150000
> + 312000 1100000
> + 144000 1050000
> + >;
> +};
Have you used the default OPPs and it turned out to be unstable, or is
it just some copy / paste from the FEX file?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-27 19:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 18:41 [PATCH resend 0/1] ARM: dts: sun7i: Add dts file for the lamobo-r1 board Hans de Goede
2016-01-27 18:41 ` Hans de Goede
2016-01-27 18:41 ` [PATCH resend] " Hans de Goede
2016-01-27 18:41 ` Hans de Goede
2016-01-27 19:47 ` Maxime Ripard [this message]
2016-01-27 19:47 ` Maxime Ripard
2016-01-28 7:49 ` Hans de Goede
2016-01-28 7:49 ` Hans de Goede
2016-02-01 6:33 ` Maxime Ripard
2016-02-01 6:33 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127194735.GT4317@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.