All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/2] microblaze: clean includes
Date: Wed, 27 Jan 2016 21:04:02 +0100	[thread overview]
Message-ID: <20160127200402.GD8630@toto> (raw)
In-Reply-To: <1453831531-667-1-git-send-email-peter.maydell@linaro.org>

On Tue, Jan 26, 2016 at 06:05:29PM +0000, Peter Maydell wrote:
> I'm sending this small series separately because cleaning
> the microblaze files' use of includes requires a manual
> code fix to disas/microblaze.c. That file manually defines
> TRUE and FALSE, which clash with the standard defines
> that osdep.h will pull in. Patch 1 fixes this, and then
> patch 2 is the usual automated cleanup of the remaining
> files.


Ack on both patches, thanks

Acked-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> 
> thanks
> -- PMM
> 
> 
> Peter Maydell (2):
>   disas/microblaze.c: Don't define TRUE or FALSE
>   microblaze: Clean up includes
> 
>  disas/microblaze.c                       | 5 +----
>  hw/microblaze/boot.c                     | 1 +
>  hw/microblaze/petalogix_ml605_mmu.c      | 1 +
>  hw/microblaze/petalogix_s3adsp1800_mmu.c | 1 +
>  target-microblaze/cpu.c                  | 1 +
>  target-microblaze/gdbstub.c              | 2 +-
>  target-microblaze/helper.c               | 1 +
>  target-microblaze/mmu.c                  | 1 +
>  target-microblaze/op_helper.c            | 1 +
>  target-microblaze/translate.c            | 1 +
>  10 files changed, 10 insertions(+), 5 deletions(-)
> 
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2016-01-27 20:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 18:05 [Qemu-devel] [PATCH 0/2] microblaze: clean includes Peter Maydell
2016-01-26 18:05 ` [Qemu-devel] [PATCH 1/2] disas/microblaze.c: Don't define TRUE or FALSE Peter Maydell
2016-01-26 18:44   ` Eric Blake
2016-01-26 18:05 ` [Qemu-devel] [PATCH 2/2] microblaze: Clean up includes Peter Maydell
2016-01-27 20:04 ` Edgar E. Iglesias [this message]
2016-01-28 11:47   ` [Qemu-devel] [PATCH 0/2] microblaze: clean includes Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160127200402.GD8630@toto \
    --to=edgar.iglesias@gmail.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.