From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] disas/microblaze.c: Don't define TRUE or FALSE
Date: Tue, 26 Jan 2016 11:44:50 -0700 [thread overview]
Message-ID: <56A7BEA2.1000000@redhat.com> (raw)
In-Reply-To: <1453831531-667-2-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On 01/26/2016 11:05 AM, Peter Maydell wrote:
> Don't define TRUE and FALSE locally or manually include stdio.h;
> instead use osdep.h which provides them.
>
> This is a necessary prerequisite for moving to "everywhere includes
> osdep.h", because otherwise there is a compile error due to the
> redefinition of TRUE and FALSE.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> disas/microblaze.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-01-26 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 18:05 [Qemu-devel] [PATCH 0/2] microblaze: clean includes Peter Maydell
2016-01-26 18:05 ` [Qemu-devel] [PATCH 1/2] disas/microblaze.c: Don't define TRUE or FALSE Peter Maydell
2016-01-26 18:44 ` Eric Blake [this message]
2016-01-26 18:05 ` [Qemu-devel] [PATCH 2/2] microblaze: Clean up includes Peter Maydell
2016-01-27 20:04 ` [Qemu-devel] [PATCH 0/2] microblaze: clean includes Edgar E. Iglesias
2016-01-28 11:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A7BEA2.1000000@redhat.com \
--to=eblake@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.