From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Pavel Rojtberg <rojtberg@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: xpad: remove unused function
Date: Wed, 27 Jan 2016 15:43:03 -0800 [thread overview]
Message-ID: <20160127234303.GG28687@dtor-ws> (raw)
In-Reply-To: <1453735884-1958624-1-git-send-email-arnd@arndb.de>
On Mon, Jan 25, 2016 at 04:30:41PM +0100, Arnd Bergmann wrote:
> There are two definitions of xpad_identify_controller(), one is used
> when CONFIG_JOYSTICK_XPAD_LEDS is set, but the other one is empty
> and never used, and we get a gcc warning about it:
>
> drivers/input/joystick/xpad.c:1210:13: warning: 'xpad_identify_controller' defined but not used [-Wunused-function]
>
> This removes the second definition.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cae705baa40b ("Input: xpad - re-send LED command on present event")
Applied, thank you.
> ---
> drivers/input/joystick/xpad.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6727954ab74b..e8a84d12b7ff 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -1207,7 +1207,6 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
> #else
> static int xpad_led_probe(struct usb_xpad *xpad) { return 0; }
> static void xpad_led_disconnect(struct usb_xpad *xpad) { }
> -static void xpad_identify_controller(struct usb_xpad *xpad) { }
> #endif
>
> static int xpad_start_input(struct usb_xpad *xpad)
> --
> 2.7.0
>
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] input: xpad: remove unused function
Date: Wed, 27 Jan 2016 15:43:03 -0800 [thread overview]
Message-ID: <20160127234303.GG28687@dtor-ws> (raw)
In-Reply-To: <1453735884-1958624-1-git-send-email-arnd@arndb.de>
On Mon, Jan 25, 2016 at 04:30:41PM +0100, Arnd Bergmann wrote:
> There are two definitions of xpad_identify_controller(), one is used
> when CONFIG_JOYSTICK_XPAD_LEDS is set, but the other one is empty
> and never used, and we get a gcc warning about it:
>
> drivers/input/joystick/xpad.c:1210:13: warning: 'xpad_identify_controller' defined but not used [-Wunused-function]
>
> This removes the second definition.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cae705baa40b ("Input: xpad - re-send LED command on present event")
Applied, thank you.
> ---
> drivers/input/joystick/xpad.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6727954ab74b..e8a84d12b7ff 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -1207,7 +1207,6 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
> #else
> static int xpad_led_probe(struct usb_xpad *xpad) { return 0; }
> static void xpad_led_disconnect(struct usb_xpad *xpad) { }
> -static void xpad_identify_controller(struct usb_xpad *xpad) { }
> #endif
>
> static int xpad_start_input(struct usb_xpad *xpad)
> --
> 2.7.0
>
--
Dmitry
next prev parent reply other threads:[~2016-01-27 23:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:30 [PATCH] input: xpad: remove unused function Arnd Bergmann
2016-01-25 15:30 ` Arnd Bergmann
2016-01-27 23:43 ` Dmitry Torokhov [this message]
2016-01-27 23:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127234303.GG28687@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.