From: Shawn Guo <shawnguo@kernel.org>
To: Carlos Soto <csotoalonso@gmail.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] imx25: Fix LCD pixelclock configuration
Date: Thu, 28 Jan 2016 14:32:13 +0800 [thread overview]
Message-ID: <20160128063213.GJ9070@tiger> (raw)
In-Reply-To: <1450902610-27224-1-git-send-email-csotoalonso@gmail.com>
On Wed, Dec 23, 2015 at 09:30:10PM +0100, Carlos Soto wrote:
> Set LCDC base clock (per_7) parent clock to UPLL clock.
> This is needed to allow finer resolution in pixelclock
>
> Signed-off-by: Carlos Soto <csotoalonso@gmail.com>
> ---
> drivers/clk/imx/clk-imx25.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
> index c4c141c..656340e 100644
> --- a/drivers/clk/imx/clk-imx25.c
> +++ b/drivers/clk/imx/clk-imx25.c
> @@ -238,6 +238,12 @@ static int __init __mx25_clocks_init(unsigned long osc_rate,
> clk_set_parent(clk[per5_sel], clk[ahb]);
>
> /*
> + * set LCDC base clock (per 7) to highest possible frequency (UPLL)
> + * to get best resolution for pixel clock
> + */
> + clk_set_parent(clk[per7_sel], clk[upll]);
This can be done in device tree via assigned-clock-parents without the
need of touching kernel.
Shawn
> +
> + /*
> * Let's initially set up CLKO parent as ipg, since this configuration
> * is used on some imx25 board designs to clock the audio codec.
> */
> --
> 1.7.10.4
>
>
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] imx25: Fix LCD pixelclock configuration
Date: Thu, 28 Jan 2016 14:32:13 +0800 [thread overview]
Message-ID: <20160128063213.GJ9070@tiger> (raw)
In-Reply-To: <1450902610-27224-1-git-send-email-csotoalonso@gmail.com>
On Wed, Dec 23, 2015 at 09:30:10PM +0100, Carlos Soto wrote:
> Set LCDC base clock (per_7) parent clock to UPLL clock.
> This is needed to allow finer resolution in pixelclock
>
> Signed-off-by: Carlos Soto <csotoalonso@gmail.com>
> ---
> drivers/clk/imx/clk-imx25.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx25.c b/drivers/clk/imx/clk-imx25.c
> index c4c141c..656340e 100644
> --- a/drivers/clk/imx/clk-imx25.c
> +++ b/drivers/clk/imx/clk-imx25.c
> @@ -238,6 +238,12 @@ static int __init __mx25_clocks_init(unsigned long osc_rate,
> clk_set_parent(clk[per5_sel], clk[ahb]);
>
> /*
> + * set LCDC base clock (per 7) to highest possible frequency (UPLL)
> + * to get best resolution for pixel clock
> + */
> + clk_set_parent(clk[per7_sel], clk[upll]);
This can be done in device tree via assigned-clock-parents without the
need of touching kernel.
Shawn
> +
> + /*
> * Let's initially set up CLKO parent as ipg, since this configuration
> * is used on some imx25 board designs to clock the audio codec.
> */
> --
> 1.7.10.4
>
>
next prev parent reply other threads:[~2016-01-28 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 20:30 [PATCH 1/1] imx25: Fix LCD pixelclock configuration Carlos Soto
2015-12-23 20:30 ` Carlos Soto
2016-01-28 6:32 ` Shawn Guo [this message]
2016-01-28 6:32 ` Shawn Guo
2016-02-07 18:59 ` Carlos Soto
2016-02-07 18:59 ` Carlos Soto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128063213.GJ9070@tiger \
--to=shawnguo@kernel.org \
--cc=csotoalonso@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.