From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Andy Shevchenko
<andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: "Elliott,
Robert (Persistent Memory)"
<elliott-ZPxbGqLxI0U@public.gmane.org>,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
James Bottomley
<James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Ingo Molnar <mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"H . Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rasmus Villemoes
<linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"linux-kernel @ vger . kernel . org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap
Date: Thu, 28 Jan 2016 09:29:59 +0000 [thread overview]
Message-ID: <20160128092959.GA2571@codeblueprint.co.uk> (raw)
In-Reply-To: <1453809566.2521.239.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Tue, 26 Jan, at 01:59:26PM, Andy Shevchenko wrote:
> On Tue, 2016-01-26 at 11:50 +0000, Matt Fleming wrote:
> > On Mon, 25 Jan, at 08:37:58PM, Elliott, Robert (Persistent Memory)
> > wrote:
> > >
> > > For the UEFI memory map, that was indeed my intention. I
> > > don't want it silently round to "20 GiB". Even rounding
> > > to "19.999 GiB" is imprecise.
> >
> > OK, let's just go with your original patch Robert (minus the @ addr
> > bit) since it's pretty small and does what we want for this specific
> > case.
>
> However I am against this, but seems reviewers do not leave a chance to
> us, I would propose to copy-and-paste table of binary prefixes and use
> __ffs64().
Is there a benefit to this approach other than __ffs64() being faster?
It is a neglibible performance gain anyway because this is hidden
behind efi=debug, and so by definition you're not looking for ultra
performance.
Which makes picking between __ffs64() and non-__ffs64() a wash if
we're not going to be reusing existing code.
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel @ vger . kernel . org"
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap
Date: Thu, 28 Jan 2016 09:29:59 +0000 [thread overview]
Message-ID: <20160128092959.GA2571@codeblueprint.co.uk> (raw)
In-Reply-To: <1453809566.2521.239.camel@linux.intel.com>
On Tue, 26 Jan, at 01:59:26PM, Andy Shevchenko wrote:
> On Tue, 2016-01-26 at 11:50 +0000, Matt Fleming wrote:
> > On Mon, 25 Jan, at 08:37:58PM, Elliott, Robert (Persistent Memory)
> > wrote:
> > >
> > > For the UEFI memory map, that was indeed my intention. I
> > > don't want it silently round to "20 GiB". Even rounding
> > > to "19.999 GiB" is imprecise.
> >
> > OK, let's just go with your original patch Robert (minus the @ addr
> > bit) since it's pretty small and does what we want for this specific
> > case.
>
> However I am against this, but seems reviewers do not leave a chance to
> us, I would propose to copy-and-paste table of binary prefixes and use
> __ffs64().
Is there a benefit to this approach other than __ffs64() being faster?
It is a neglibible performance gain anyway because this is hidden
behind efi=debug, and so by definition you're not looking for ultra
performance.
Which makes picking between __ffs64() and non-__ffs64() a wash if
we're not going to be reusing existing code.
next prev parent reply other threads:[~2016-01-28 9:29 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 14:55 [PATCH v3 0/4] x86/efi: use binary units when printing Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 1/4] lib/string_helpers: export string_units_{2,10} for others Andy Shevchenko
[not found] ` <1453560913-134672-2-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-23 16:14 ` James Bottomley
2016-01-23 16:14 ` James Bottomley
[not found] ` <1453565662.2470.5.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-23 16:58 ` Andy Shevchenko
2016-01-23 16:58 ` Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 2/4] lib/string_helpers: fix indentation in few places Andy Shevchenko
2016-01-23 14:55 ` [PATCH v3 3/4] x86/efi: print size in binary units in efi_print_memmap Andy Shevchenko
[not found] ` <1453560913-134672-4-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-23 16:44 ` James Bottomley
2016-01-23 16:44 ` James Bottomley
[not found] ` <1453567445.2470.24.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-23 17:18 ` Andy Shevchenko
2016-01-23 17:18 ` Andy Shevchenko
[not found] ` <CAHp75Vdc9=uotvaf4pQfRoViyWuEXhXjZH7GVWEG79AquPVi5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-23 18:03 ` James Bottomley
2016-01-23 18:03 ` James Bottomley
[not found] ` <1453572191.2470.52.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-25 8:31 ` Andy Shevchenko
2016-01-25 8:31 ` Andy Shevchenko
[not found] ` <1453710713.2521.200.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-25 15:25 ` James Bottomley
2016-01-25 15:25 ` James Bottomley
2016-01-23 18:12 ` James Bottomley
2016-01-23 18:12 ` James Bottomley
2016-01-23 20:29 ` One Thousand Gnomes
[not found] ` <20160123202926.460b284f-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
2016-01-23 20:43 ` H. Peter Anvin
2016-01-23 20:43 ` H. Peter Anvin
2016-01-25 18:02 ` Elliott, Robert (Persistent Memory)
2016-01-25 18:02 ` Elliott, Robert (Persistent Memory)
[not found] ` <94D0CD8314A33A4D9D801C0FE68B40295BF3B840-W1gbDvblbosSZAcGdq5asR6epYMZPwEe5NbjCUgZEJk@public.gmane.org>
2016-01-25 18:56 ` James Bottomley
2016-01-25 18:56 ` James Bottomley
[not found] ` <1453748172.2363.36.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-25 19:28 ` Andy Shevchenko
2016-01-25 19:28 ` Andy Shevchenko
[not found] ` <CAHp75VdYRzC9TcDpKxq=xddA0zgVk=5_25uXaimn1tOMZVeK4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 19:45 ` James Bottomley
2016-01-25 19:45 ` James Bottomley
[not found] ` <1453751131.2363.54.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-25 20:01 ` Andy Shevchenko
2016-01-25 20:01 ` Andy Shevchenko
[not found] ` <CAHp75VeXHoyOgFSb4vzWBmELH_yJx1mSN+quxue=tSZCh5sTXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-25 20:18 ` James Bottomley
2016-01-25 20:18 ` James Bottomley
2016-01-25 20:37 ` Elliott, Robert (Persistent Memory)
2016-01-25 20:37 ` Elliott, Robert (Persistent Memory)
2016-01-26 11:50 ` Matt Fleming
[not found] ` <20160126115041.GA7478-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-01-26 11:59 ` Andy Shevchenko
2016-01-26 11:59 ` Andy Shevchenko
[not found] ` <1453809566.2521.239.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-28 9:29 ` Matt Fleming [this message]
2016-01-28 9:29 ` Matt Fleming
2016-01-28 11:15 ` Andy Shevchenko
2016-01-28 11:15 ` Andy Shevchenko
2016-01-25 20:44 ` James Bottomley
2016-01-25 20:44 ` James Bottomley
[not found] ` <1453560913-134672-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-23 14:55 ` [PATCH v3 4/4] x86/efi: Use proper units in efi_find_mirror() Andy Shevchenko
2016-01-23 14:55 ` Andy Shevchenko
2016-01-23 16:34 ` [PATCH v3 0/4] x86/efi: use binary units when printing James Bottomley
2016-01-23 16:34 ` James Bottomley
[not found] ` <1453566877.2470.15.camel-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org>
2016-01-23 17:20 ` Andy Shevchenko
2016-01-23 17:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128092959.GA2571@codeblueprint.co.uk \
--to=matt-mf/unelci9gs6ibeejttw/xrex20p6io@public.gmane.org \
--cc=James.Bottomley-JuX6DAaQMKPCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=elliott-ZPxbGqLxI0U@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-qQsb+v5E8BnlAoU/VqSP6n9LOBIZ5rWg@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.