All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: "Darrick J. Wong" <darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] man2: document FICLONE and FICLONERANGE
Date: Thu, 28 Jan 2016 05:33:29 -0800	[thread overview]
Message-ID: <20160128133329.GA7610@infradead.org> (raw)
In-Reply-To: <20151219085613.12660.75735.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>

Now that we have this in 4.5-rc1 let's get this into man-pages as well.

> --- /dev/null
> +++ b/man2/ioctl_ficlone.2

think this should be a link to the clone range man page, and the
both ioctls should be documented together.  Basically just document
FICLONERANGE and then mentiond that FICLONE does a whole file clone.

> +.B #include <sys/ioctl.h>

Don't we need uapi/linux/fs.h as well?

> Not all filesystems support
> +overlapping reflink ranges in the same file.

Which one doesn't?


Also there should be a sentence that the clones are atomic vs
concurrent writes, so no locks need to be taken for a consistent
snapshot.
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: mtk.manpages@gmail.com, linux-fsdevel@vger.kernel.org,
	linux-api@vger.kernel.org, linux-man@vger.kernel.org
Subject: Re: [PATCH 1/2] man2: document FICLONE and FICLONERANGE
Date: Thu, 28 Jan 2016 05:33:29 -0800	[thread overview]
Message-ID: <20160128133329.GA7610@infradead.org> (raw)
In-Reply-To: <20151219085613.12660.75735.stgit@birch.djwong.org>

Now that we have this in 4.5-rc1 let's get this into man-pages as well.

> --- /dev/null
> +++ b/man2/ioctl_ficlone.2

think this should be a link to the clone range man page, and the
both ioctls should be documented together.  Basically just document
FICLONERANGE and then mentiond that FICLONE does a whole file clone.

> +.B #include <sys/ioctl.h>

Don't we need uapi/linux/fs.h as well?

> Not all filesystems support
> +overlapping reflink ranges in the same file.

Which one doesn't?


Also there should be a sentence that the clones are atomic vs
concurrent writes, so no locks need to be taken for a consistent
snapshot.

  parent reply	other threads:[~2016-01-28 13:33 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19  8:56 [RFCv4 0/2] man-pages: document reflink/dedupe ioctls Darrick J. Wong
2015-12-19  8:56 ` Darrick J. Wong
2015-12-19  8:56 ` [PATCH 1/2] man2: document FICLONE and FICLONERANGE Darrick J. Wong
     [not found]   ` <20151219085613.12660.75735.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-01-28 13:33     ` Christoph Hellwig [this message]
2016-01-28 13:33       ` Christoph Hellwig
     [not found]       ` <20160128133329.GA7610-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-01-28 19:18         ` Darrick J. Wong
2016-01-28 19:18           ` Darrick J. Wong
     [not found]           ` <20160128191814.GA5849-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-15  8:27             ` Christoph Hellwig
2016-03-15  8:27               ` Christoph Hellwig
     [not found]               ` <20160315082737.GA1498-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-03-15 16:35                 ` Darrick J. Wong
2016-03-15 16:35                   ` Darrick J. Wong
     [not found] ` <20151219085607.12660.75196.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2015-12-19  8:56   ` [PATCH 2/2] man2: document the FIDEDUPERANGE ioctl Darrick J. Wong
2015-12-19  8:56     ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2016-03-15 16:48 [PATCH v5 0/2] man-pages: document reflink/dedupe ioctls Darrick J. Wong
     [not found] ` <20160315164804.30909.83270.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-15 16:48   ` [PATCH 1/2] man2: document FICLONE and FICLONERANGE Darrick J. Wong
2016-03-15 16:48     ` Darrick J. Wong
     [not found]     ` <20160315164810.30909.3152.stgit-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2016-03-19 17:04       ` walter harms
2016-03-19 17:04         ` walter harms
     [not found]         ` <56ED86B6.2000506-fPG8STNUNVg@public.gmane.org>
2016-03-20 19:13           ` Darrick J. Wong
2016-03-20 19:13             ` Darrick J. Wong
2016-06-08 10:35       ` Michael Kerrisk (man-pages)
2016-06-08 10:35         ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160128133329.GA7610@infradead.org \
    --to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=darrick.wong-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.