Re: [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

[Wei Liu <wei.liu2@citrix.com>]

On Thu, Jan 28, 2016 at 07:30:31AM -0700, Lengyel, Tamas wrote:
> On Jan 28, 2016 4:00 AM, "Wei Liu" <wei.liu2@citrix.com> wrote:
> >
> > On Thu, Jan 28, 2016 at 10:55:36AM +0000, Ian Campbell wrote:
> > > --- a/tools/libxc/include/xenctrl.h
> > > > > +++ b/tools/libxc/include/xenctrl.h
> > > > > @@ -2027,9 +2027,6 @@ int xc_altp2m_destroy_view(xc_interface
> *handle,
> > > > > domid_t domid,
> > > > >  /* Switch all vCPUs of the domain to the specified altp2m view */
> > > > >  int xc_altp2m_switch_to_view(xc_interface *handle, domid_t domid,
> > > > >                               uint16_t view_id);
> > > > > -int xc_altp2m_set_mem_access(xc_interface *handle, domid_t domid,
> > > > > -                             uint16_t view_id, xen_pfn_t gfn,
> > > > > -                             xenmem_access_t access);
> > > >
> > > > What is the support status of these APIs in libxc? Are they supposed
> to
> > > > be stable now? Do you have opinion on making them stable interfaces?
> > >
> > > Nothing in libxc is ever a stable interface. It is always completely
> fine
> > > to change them if that is what is needed.
> > >
> >
> > Right. Ignore the first question and this patch is ready to go in when
> > those nits are fixed.
> >
> > It would still be nice if we can get a libmemaccess or some sort so that
> > people can build on top of it. Just curious if that's feasible.
> >
> > Wei.
> 
> There is LibVMI and Bitdefender also released its library so there are
> choices if folks find libxc too volatile.

Thanks, this makes sense.

Wei.

> 
> Tamas