Re: [PATCH 1/2] altp2m: Merge p2m_set_altp2m_mem_access and p2m_set_mem_access

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 01/27/2016 10:06 PM, Tamas K Lengyel wrote:
> The altp2m subsystem in its current form uses its own HVMOP hypercall to set
> mem_access permissions, duplicating some of the code already present for
> setting regular mem_access permissions. In this patch we consolidate the two,
> deprecate the HVMOP hypercall and update the corresponding tools.
> 
> Signed-off-by: Tamas K Lengyel <tlengyel@novetta.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
> Cc: Stefano Stabellini <stefano.stabellini@citrix.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> Cc: George Dunlap <george.dunlap@eu.citrix.com>
> ---
>  tools/libxc/include/xenctrl.h       |   5 +-
>  tools/libxc/xc_altp2m.c             |  25 ------
>  tools/libxc/xc_mem_access.c         |  14 +--
>  tools/tests/xen-access/xen-access.c |  53 ++++-------
>  xen/arch/arm/p2m.c                  |   9 +-
>  xen/arch/x86/hvm/hvm.c              |   9 --
>  xen/arch/x86/mm/p2m.c               | 169 ++++++++++++++++--------------------
>  xen/common/mem_access.c             |   2 +-
>  xen/include/asm-x86/p2m.h           |   4 -
>  xen/include/public/hvm/hvm_op.h     |  15 +---
>  xen/include/public/memory.h         |   3 +
>  xen/include/xen/p2m-common.h        |   3 +-
>  12 files changed, 115 insertions(+), 196 deletions(-)

For the part of the code in the files we're maintaining:

Acked-by: Razvan Cojocaru <rcojocaru@bitdefender.com>

Thanks for doing this, as also discussed in private I think something
along these lines is a much needed change here.


Thanks,
Razvan