From: Mark Brown <broonie@kernel.org>
To: John Crispin <blogic@openwrt.org>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Chen Zhong" <chen.zhong@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"HenryC Chen (陳建豪)" <HenryC.Chen@mediatek.com>
Subject: Re: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Fri, 29 Jan 2016 00:13:06 +0100 [thread overview]
Message-ID: <20160128231306.GD4130@sirena.org.uk> (raw)
In-Reply-To: <56AA5A5C.9080402@openwrt.org>
[-- Attachment #1: Type: text/plain, Size: 724 bytes --]
On Thu, Jan 28, 2016 at 07:13:48PM +0100, John Crispin wrote:
> would the following two bindings be ok ? I would create patches to add them.
> * regulator-allow-mode; or regulator-allow-change-mode;
This seems redundant, if we have a list of valid modes presumably they
can be used - same idea as with voltage setting.
> * regulator-modes = <REGULATOR_MODE_NORMAL REGULATOR_MODE_STANDBY>;
I'm not convinced this binding makes sense, how would a user of the API
(currently there are none in tree) know what the modes mean? It's a bit
different when the user is supplying configuration for a specific
regulator but this needs to be something that can be used by consumers.
What are you actually trying to do with this?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/2] regulator: mt6323: Add support for MT6323 regulator
Date: Fri, 29 Jan 2016 00:13:06 +0100 [thread overview]
Message-ID: <20160128231306.GD4130@sirena.org.uk> (raw)
In-Reply-To: <56AA5A5C.9080402@openwrt.org>
On Thu, Jan 28, 2016 at 07:13:48PM +0100, John Crispin wrote:
> would the following two bindings be ok ? I would create patches to add them.
> * regulator-allow-mode; or regulator-allow-change-mode;
This seems redundant, if we have a list of valid modes presumably they
can be used - same idea as with voltage setting.
> * regulator-modes = <REGULATOR_MODE_NORMAL REGULATOR_MODE_STANDBY>;
I'm not convinced this binding makes sense, how would a user of the API
(currently there are none in tree) know what the modes mean? It's a bit
different when the user is supplying configuration for a specific
regulator but this needs to be something that can be used by consumers.
What are you actually trying to do with this?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160129/23cb432c/attachment.sig>
next prev parent reply other threads:[~2016-01-28 23:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 12:00 [PATCH V4 1/2] regulator: Add document for MT6323 regulator John Crispin
2016-01-27 12:00 ` John Crispin
2016-01-27 12:00 ` John Crispin
2016-01-27 12:00 ` [PATCH V4 2/2] regulator: mt6323: Add support " John Crispin
2016-01-27 12:00 ` John Crispin
2016-01-27 14:41 ` Mark Brown
2016-01-27 14:41 ` Mark Brown
2016-01-28 7:16 ` Henry Chen
2016-01-28 7:16 ` Henry Chen
2016-01-28 7:16 ` Henry Chen
2016-01-28 11:38 ` Mark Brown
2016-01-28 11:38 ` Mark Brown
[not found] ` <20160127144105.GQ6042-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-28 18:13 ` John Crispin
2016-01-28 18:13 ` John Crispin
2016-01-28 18:13 ` John Crispin
2016-01-28 23:13 ` Mark Brown [this message]
2016-01-28 23:13 ` Mark Brown
2016-01-29 9:52 ` menghui lin
2016-01-29 9:52 ` menghui lin
2016-01-29 11:27 ` Mark Brown
2016-01-29 11:27 ` Mark Brown
2016-01-29 12:11 ` menghui lin
2016-01-29 12:11 ` menghui lin
2016-02-02 19:38 ` Mark Brown
2016-02-02 19:38 ` Mark Brown
2016-02-03 5:39 ` menghui lin
2016-02-03 5:39 ` menghui lin
2016-02-03 12:29 ` Mark Brown
2016-02-03 12:29 ` Mark Brown
2016-02-04 2:42 ` menghui lin
2016-02-04 2:42 ` menghui lin
2016-02-02 19:39 ` Mark Brown
2016-02-02 19:39 ` Mark Brown
2016-02-08 12:14 ` kbuild test robot
2016-02-08 12:14 ` kbuild test robot
2016-02-08 12:14 ` kbuild test robot
2016-02-01 15:40 ` [PATCH V4 1/2] regulator: Add document " Rob Herring
2016-02-01 15:40 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128231306.GD4130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=HenryC.Chen@mediatek.com \
--cc=blogic@openwrt.org \
--cc=chen.zhong@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.