[PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB

[PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB

[Jeremy McNicoll]

Fix a simple typo when disabling IOTLB on PCI(e) devices.

Fixes: b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI capabilities before ATS")
Signed-off-by: Jeremy McNicoll <jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index ac73876..986a53e 100644
--- a/drivers/iommu/intel-iommu.c
+++ b/drivers/iommu/intel-iommu.c
@@ -1489,7 +1489,7 @@ static void iommu_disable_dev_iotlb(struct device_domain_info *info)
 {
 	struct pci_dev *pdev;
 
-	if (dev_is_pci(info->dev))
+	if (!dev_is_pci(info->dev))
 		return;
 
 	pdev = to_pci_dev(info->dev);
-- 
2.6.1

Re: [PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB

[Alex Williamson]

On Thu, 2016-01-14 at 21:33 -0800, Jeremy McNicoll wrote:
> Fix a simple typo when disabling IOTLB on PCI(e) devices.
> 
> Fixes: b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI
> capabilities before ATS")
> Signed-off-by: Jeremy McNicoll <jmcnicol@redhat.com>
> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-
> iommu.c
> index ac73876..986a53e 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1489,7 +1489,7 @@ static void iommu_disable_dev_iotlb(struct
> device_domain_info *info)
>  {
>  	struct pci_dev *pdev;
>  
> -	if (dev_is_pci(info->dev))
> +	if (!dev_is_pci(info->dev))
>  		return;
>  
>  	pdev = to_pci_dev(info->dev);

Looks like a pretty obvious typo/thinko to me.  I'd probably suggest it
for v4.4 stable too.

Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

Re: [PATCH] iommu/vt-d: Don't skip PCI devices when disabling IOTLB

[Joerg Roedel]

On Thu, Jan 14, 2016 at 09:33:06PM -0800, Jeremy McNicoll wrote:
> Fix a simple typo when disabling IOTLB on PCI(e) devices.
> 
> Fixes: b16d0cb9e2fc ("iommu/vt-d: Always enable PASID/PRI PCI capabilities before ATS")
> Signed-off-by: Jeremy McNicoll <jmcnicol-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.