* [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller
@ 2016-01-29 13:38 ` Stafford Horne
0 siblings, 0 replies; 4+ messages in thread
From: Stafford Horne @ 2016-01-29 13:38 UTC (permalink / raw)
To: jikos
Cc: benjamin.tissoires, linux-input, linux-kernel, linux-usb,
Stafford Horne
The midi controller times-out while initializing reports, this
causes boot to take an extra 10 seconds. The device descriptor
advertises that it has an internal HID device but seems to not
actually do anything useful.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
Resending the same patch for the keyboard to simply disable init reports,
as discussed with Oliver there might be some hidden functionality which
I will look into. At the moment I dont want to worry about time timeouts.
Also, I did create and test a patch to use HID_QUIRK_IGNORE which I can
send if you feel strongly about it.
Changes in v2
- use tabs instead of spaces in hid-ids.h
drivers/hid/hid-ids.h | 3 +++
drivers/hid/usbhid/hid-quirks.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b6ff6e7..74ed730 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -61,6 +61,9 @@
#define USB_VENDOR_ID_AIREN 0x1a2c
#define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
+#define USB_VENDOR_ID_AKAI 0x2011
+#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
+
#define USB_VENDOR_ID_ALCOR 0x058f
#define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 7dd0953..055e740 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -55,6 +55,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
+ { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-29 13:38 ` Stafford Horne
(?)
@ 2016-01-29 13:40 ` Benjamin Tissoires
-1 siblings, 0 replies; 4+ messages in thread
From: Benjamin Tissoires @ 2016-01-29 13:40 UTC (permalink / raw)
To: Stafford Horne; +Cc: jikos, linux-input, linux-kernel, linux-usb
On Jan 29 2016 or thereabouts, Stafford Horne wrote:
> The midi controller times-out while initializing reports, this
> causes boot to take an extra 10 seconds. The device descriptor
> advertises that it has an internal HID device but seems to not
> actually do anything useful.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
Works for me:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> ---
> Resending the same patch for the keyboard to simply disable init reports,
> as discussed with Oliver there might be some hidden functionality which
> I will look into. At the moment I dont want to worry about time timeouts.
>
> Also, I did create and test a patch to use HID_QUIRK_IGNORE which I can
> send if you feel strongly about it.
>
> Changes in v2
> - use tabs instead of spaces in hid-ids.h
>
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..74ed730 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -61,6 +61,9 @@
> #define USB_VENDOR_ID_AIREN 0x1a2c
> #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
>
> +#define USB_VENDOR_ID_AKAI 0x2011
> +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
> +
> #define USB_VENDOR_ID_ALCOR 0x058f
> #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 7dd0953..055e740 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -55,6 +55,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>
> { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
> + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-29 13:38 ` Stafford Horne
(?)
(?)
@ 2016-01-29 15:40 ` Jiri Kosina
-1 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2016-01-29 15:40 UTC (permalink / raw)
To: Stafford Horne; +Cc: benjamin.tissoires, linux-input, linux-kernel, linux-usb
On Fri, 29 Jan 2016, Stafford Horne wrote:
> The midi controller times-out while initializing reports, this
> causes boot to take an extra 10 seconds. The device descriptor
> advertises that it has an internal HID device but seems to not
> actually do anything useful.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> Resending the same patch for the keyboard to simply disable init reports,
> as discussed with Oliver there might be some hidden functionality which
> I will look into. At the moment I dont want to worry about time timeouts.
>
> Also, I did create and test a patch to use HID_QUIRK_IGNORE which I can
> send if you feel strongly about it.
Applied to for-4.5/upstream-fixes.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread