From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] tpm, tpm_crb: fix control area resource mapping
Date: Fri, 29 Jan 2016 14:21:08 -0800 [thread overview]
Message-ID: <20160129222108.GA25327@intel.com> (raw)
In-Reply-To: <20160129204826.GA30177-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
>
> > - struct resource tmp = {};
> > -
> > - tmp.start = start;
> > - tmp.end = start + size - 1;
> > - tmp.flags = IORESOURCE_MEM;
> > + struct resource new_res = {
> > + .start = start,
> > + .end = size - 1,
>
> That isn't right.
Whoops. Good catch, I'll update it before pull request. Thanks!
> Jason
/Jarkko
------------------------------------------------------------------------------
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping
Date: Fri, 29 Jan 2016 14:21:08 -0800 [thread overview]
Message-ID: <20160129222108.GA25327@intel.com> (raw)
In-Reply-To: <20160129204826.GA30177@obsidianresearch.com>
On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
>
> > - struct resource tmp = {};
> > -
> > - tmp.start = start;
> > - tmp.end = start + size - 1;
> > - tmp.flags = IORESOURCE_MEM;
> > + struct resource new_res = {
> > + .start = start,
> > + .end = size - 1,
>
> That isn't right.
Whoops. Good catch, I'll update it before pull request. Thanks!
> Jason
/Jarkko
next prev parent reply other threads:[~2016-01-29 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 7:13 [PATCH] tpm, tpm_crb: fix control area resource mapping Jarkko Sakkinen
[not found] ` <1454051639-15961-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-01-29 20:48 ` Jason Gunthorpe
2016-01-29 20:48 ` [tpmdd-devel] " Jason Gunthorpe
[not found] ` <20160129204826.GA30177-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-29 22:21 ` Jarkko Sakkinen [this message]
2016-01-29 22:21 ` Jarkko Sakkinen
[not found] ` <20160129222108.GA25327-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-29 22:26 ` Jarkko Sakkinen
2016-01-29 22:26 ` [tpmdd-devel] " Jarkko Sakkinen
[not found] ` <20160129222654.GB25327-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-01-29 22:33 ` Jason Gunthorpe
2016-01-29 22:33 ` [tpmdd-devel] " Jason Gunthorpe
[not found] ` <20160129223334.GA14129-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-01-29 22:39 ` Jarkko Sakkinen
2016-01-29 22:39 ` [tpmdd-devel] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129222108.GA25327@intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.