* [patch] mac80211: free sinfo on error path
@ 2016-01-30 14:39 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-30 14:39 UTC (permalink / raw)
To: Johannes Berg, Arnd Bergmann; +Cc: linux-wireless, kernel-janitors
There is a missing kfree(sinfo) on error in sta_info_insert_finish().
Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6c198e6..1502efb 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
out_err:
mutex_unlock(&local->sta_mtx);
rcu_read_lock();
+ kfree(sinfo);
return err;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] mac80211: free sinfo on error path
@ 2016-01-30 14:39 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-30 14:39 UTC (permalink / raw)
To: Johannes Berg, Arnd Bergmann; +Cc: linux-wireless, kernel-janitors
There is a missing kfree(sinfo) on error in sta_info_insert_finish().
Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6c198e6..1502efb 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
out_err:
mutex_unlock(&local->sta_mtx);
rcu_read_lock();
+ kfree(sinfo);
return err;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] mac80211: free sinfo on error path
2016-01-30 14:39 ` Dan Carpenter
@ 2016-01-30 19:58 ` Arend van Spriel
-1 siblings, 0 replies; 4+ messages in thread
From: Arend van Spriel @ 2016-01-30 19:58 UTC (permalink / raw)
To: Dan Carpenter, Johannes Berg, Arnd Bergmann
Cc: linux-wireless, kernel-janitors
On 30-01-16 15:39, Dan Carpenter wrote:
> There is a missing kfree(sinfo) on error in sta_info_insert_finish().
>
> Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
A fix for this has already been posted [1]. Although your 'Fixes:' tag
is useful to have, I guess.
Regards,
Arend
[1]
http://mid.gmane.org/1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index 6c198e6..1502efb 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
> out_err:
> mutex_unlock(&local->sta_mtx);
> rcu_read_lock();
> + kfree(sinfo);
> return err;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] mac80211: free sinfo on error path
@ 2016-01-30 19:58 ` Arend van Spriel
0 siblings, 0 replies; 4+ messages in thread
From: Arend van Spriel @ 2016-01-30 19:58 UTC (permalink / raw)
To: Dan Carpenter, Johannes Berg, Arnd Bergmann
Cc: linux-wireless, kernel-janitors
On 30-01-16 15:39, Dan Carpenter wrote:
> There is a missing kfree(sinfo) on error in sta_info_insert_finish().
>
> Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Hi Dan,
A fix for this has already been posted [1]. Although your 'Fixes:' tag
is useful to have, I guess.
Regards,
Arend
[1]
http://mid.gmane.org/1454060944-11320-1-git-send-email-sudipm.mukherjee@gmail.com
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index 6c198e6..1502efb 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
> out_err:
> mutex_unlock(&local->sta_mtx);
> rcu_read_lock();
> + kfree(sinfo);
> return err;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-30 19:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-30 14:39 [patch] mac80211: free sinfo on error path Dan Carpenter
2016-01-30 14:39 ` Dan Carpenter
2016-01-30 19:58 ` Arend van Spriel
2016-01-30 19:58 ` Arend van Spriel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.