* [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap
@ 2016-01-27 13:35 Alex Hung
2016-01-30 17:10 ` Darren Hart
0 siblings, 1 reply; 2+ messages in thread
From: Alex Hung @ 2016-01-27 13:35 UTC (permalink / raw)
To: dvhart, platform-driver-x86, alex.hung; +Cc: luto, pbludov
intel_hid_keymap contains a duplicate entry for KEY_HOME and an
incorrect HID index for KEY_PAGEDOWN
Reported-by: Pavel Bludov <pbludov@gmail.com>
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
drivers/platform/x86/intel-hid.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
index 20f0ad9..e20f23e 100644
--- a/drivers/platform/x86/intel-hid.c
+++ b/drivers/platform/x86/intel-hid.c
@@ -41,8 +41,7 @@ static const struct key_entry intel_hid_keymap[] = {
{ KE_KEY, 4, { KEY_HOME } },
{ KE_KEY, 5, { KEY_END } },
{ KE_KEY, 6, { KEY_PAGEUP } },
- { KE_KEY, 4, { KEY_PAGEDOWN } },
- { KE_KEY, 4, { KEY_HOME } },
+ { KE_KEY, 7, { KEY_PAGEDOWN } },
{ KE_KEY, 8, { KEY_RFKILL } },
{ KE_KEY, 9, { KEY_POWER } },
{ KE_KEY, 11, { KEY_SLEEP } },
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap
2016-01-27 13:35 [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap Alex Hung
@ 2016-01-30 17:10 ` Darren Hart
0 siblings, 0 replies; 2+ messages in thread
From: Darren Hart @ 2016-01-30 17:10 UTC (permalink / raw)
To: Alex Hung; +Cc: platform-driver-x86, luto, pbludov
On Wed, Jan 27, 2016 at 09:35:00PM +0800, Alex Hung wrote:
> intel_hid_keymap contains a duplicate entry for KEY_HOME and an
> incorrect HID index for KEY_PAGEDOWN
>
> Reported-by: Pavel Bludov <pbludov@gmail.com>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
Thanks Alex, queued for 4.5 fixes.
> ---
> drivers/platform/x86/intel-hid.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 20f0ad9..e20f23e 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -41,8 +41,7 @@ static const struct key_entry intel_hid_keymap[] = {
> { KE_KEY, 4, { KEY_HOME } },
> { KE_KEY, 5, { KEY_END } },
> { KE_KEY, 6, { KEY_PAGEUP } },
> - { KE_KEY, 4, { KEY_PAGEDOWN } },
> - { KE_KEY, 4, { KEY_HOME } },
> + { KE_KEY, 7, { KEY_PAGEDOWN } },
> { KE_KEY, 8, { KEY_RFKILL } },
> { KE_KEY, 9, { KEY_POWER } },
> { KE_KEY, 11, { KEY_SLEEP } },
> --
> 2.5.0
>
>
--
Darren Hart
Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-30 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 13:35 [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap Alex Hung
2016-01-30 17:10 ` Darren Hart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.