All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jay Vosburgh <jay.vosburgh@canonical.com>
Cc: "Nikolay Aleksandrov" <nikolay@cumulusnetworks.com>,
	=?UTF-8?Q?Bj=c3=b8rnar_Ness?= <bjornar.ness@gmail.com>,
	netdev <netdev@vger.kernel.org>,
	"Veaceslav Falico" <vfalico@gmail.com>,
	"Andy Gospodarek" <gospo@cumulusnetworks.com>,
	"Jiri Pirko" <jiri@resnulli.us>
Subject: Re: bonding (IEEE 802.3ad) not working with qemu/virtio
Date: Sun, 31 Jan 2016 16:35:35 +0200	[thread overview]
Message-ID: <20160131163457-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <28285.1454103900@famine>

On Fri, Jan 29, 2016 at 01:45:00PM -0800, Jay Vosburgh wrote:
> Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> 
> >On 01/25/2016 05:24 PM, Bjørnar Ness wrote:
> >> As subject says, 802.3ad bonding is not working with virtio network model.
> >> 
> >> The only errors I see is:
> >> 
> >> No 802.3ad response from the link partner for any adapters in the bond.
> >> 
> >> Dumping the network traffic shows that no LACP packets are sent from the
> >> host running with virtio driver, changing to for example e1000 solves
> >> this problem
> >> with no configuration changes.
> >> 
> >> Is this a known problem?
> >> 
> >[Including bonding maintainers for comments]
> >
> >Hi,
> >Here's a workaround patch for virtio_net devices that "cheats" the
> >duplex test (which is the actual problem). I've tested this locally
> >and it works for me.
> >I'd let the others comment on the implementation, there're other signs
> >that can be used to distinguish a virtio_net device so I'm open to suggestions.
> >Also feedback if this is at all acceptable would be appreciated.
> 
> 	Should virtio instead provide an arbitrary speed and full duplex
> to ethtool, as veth does?
> 
> 	Creating a magic whitelist of devices deep inside the 802.3ad
> implementation seems less desirable.
> 
> 	-J

Absolutely but why not tream DUPLEX_UNKNOWN as DUPLEX_FULL
and allow LACP?

> ---
> 	-Jay Vosburgh, jay.vosburgh@canonical.com

      parent reply	other threads:[~2016-01-31 14:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 16:24 bonding (IEEE 802.3ad) not working with qemu/virtio Bjørnar Ness
2016-01-28 13:33 ` Jiri Pirko
2016-01-28 13:53   ` Nikolay Aleksandrov
2016-01-28 14:10     ` Nikolay Aleksandrov
2016-01-29 21:31 ` Nikolay Aleksandrov
2016-01-29 21:45   ` Jay Vosburgh
2016-01-29 21:48     ` Nikolay Aleksandrov
2016-01-30  6:59       ` David Miller
2016-01-30 11:34         ` Jiri Pirko
2016-01-30 11:34         ` Jiri Pirko
2016-01-30 11:41         ` Nikolay Aleksandrov
2016-01-31 14:50           ` Michael S. Tsirkin
2016-01-31 14:50           ` Michael S. Tsirkin
2016-01-30 11:41         ` Nikolay Aleksandrov
2016-02-01 18:49         ` Rick Jones
2016-01-31 14:58       ` Michael S. Tsirkin
2016-01-29 21:48     ` Nikolay Aleksandrov
2016-01-31 14:35     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160131163457-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=bjornar.ness@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.