All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>,
	Magnus Damm <magnus.damm@gmail.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH v2 1/3] drm: adv7511: really enable interrupts for EDID detection
Date: Mon, 01 Feb 2016 13:29:21 +0000	[thread overview]
Message-ID: <20160201132920.GA10607@tetsubishi> (raw)
In-Reply-To: <1452290210-20629-2-git-send-email-wsa@the-dreams.de>

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On Fri, Jan 08, 2016 at 10:56:48PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> The interrupts for EDID_READY or DDC_ERROR were never enabled in this
> driver, so reading EDID always timed out when chip was powered down and
> interrupts were used. Fix this and also remove clearing the interrupt
> flags, they are cleared in POWER_DOWN mode anyhow (unlike the interrupt
> enable flags) according to docs and my tests.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Archit Taneja <architt@codeaurora.org>

Unsure who is the right person to pick it up, adding Hans to CC...


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: dri-devel@lists.freedesktop.org,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, Daniel Vetter <daniel.vetter@ffwll.ch>,
	Magnus Damm <magnus.damm@gmail.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH v2 1/3] drm: adv7511: really enable interrupts for EDID detection
Date: Mon, 1 Feb 2016 14:29:21 +0100	[thread overview]
Message-ID: <20160201132920.GA10607@tetsubishi> (raw)
In-Reply-To: <1452290210-20629-2-git-send-email-wsa@the-dreams.de>


[-- Attachment #1.1: Type: text/plain, Size: 664 bytes --]

On Fri, Jan 08, 2016 at 10:56:48PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> The interrupts for EDID_READY or DDC_ERROR were never enabled in this
> driver, so reading EDID always timed out when chip was powered down and
> interrupts were used. Fix this and also remove clearing the interrupt
> flags, they are cleared in POWER_DOWN mode anyhow (unlike the interrupt
> enable flags) according to docs and my tests.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Tested-by: Archit Taneja <architt@codeaurora.org>

Unsure who is the right person to pick it up, adding Hans to CC...


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-02-01 13:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 21:56 [PATCH v2 0/3] drm: adv7511: edid read fixes Wolfram Sang
2016-01-08 21:56 ` Wolfram Sang
2016-01-08 21:56 ` [PATCH v2 1/3] drm: adv7511: really enable interrupts for EDID detection Wolfram Sang
2016-01-08 21:56   ` Wolfram Sang
2016-02-01 13:29   ` Wolfram Sang [this message]
2016-02-01 13:29     ` Wolfram Sang
2016-01-08 21:56 ` [PATCH v2 2/3] drm: adv7511: mark ADV7511_REG_EDID_READ_CTRL volatile Wolfram Sang
2016-01-08 21:56   ` Wolfram Sang
2016-01-08 21:56 ` [PATCH v2 3/3] drm: adv7511: it's HPD, not HDP Wolfram Sang
2016-01-08 21:56   ` Wolfram Sang
2016-02-01 13:31 ` [PATCH v2 0/3] drm: adv7511: edid read fixes Wolfram Sang
2016-02-01 13:31   ` Wolfram Sang
2016-02-01 22:52   ` Laurent Pinchart
2016-02-01 22:52     ` Laurent Pinchart
2016-02-03 15:05 ` Wolfram Sang
2016-02-03 15:05   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201132920.GA10607@tetsubishi \
    --to=wsa@the-dreams.de \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hans.verkuil@cisco.com \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.