Re: [PATCH] git: add site_perl to packaged files to fix QA install error

[Paul Gortmaker <paul.gortmaker@windriver.com>]

[Re: [OE-core] [PATCH] git: add site_perl to packaged files to fix QA install error] On 31/01/2016 (Sun 21:40) Phil Blundell wrote:

> On Sun, 2016-01-31 at 13:27 -0500, Paul Gortmaker wrote:
> >  FILES_${PN}-perltools += " \
> >      ${PERLTOOLS} \
> >      ${libdir}/perl \
> > +    ${libdir}/site_perl \
> >      ${datadir}/perl \
> 
> It seems a bit wrong for git (or any other package) to be installing
> itself into site-perl.  That path is meant to be for stuff installed
> locally via cpan, right?

I'm not up to speed on perl/cpan specs, but yeah off the cuff it does
seem rather odd for it to be sprawling out into any perl dir IMHO.

Even the perl bb itself seems to actively clobber site_perl for the
non native case.

> 
> So, rather than patching the FILES to accept site-perl I think it would
> be better to find out why git is suddenly putting stuff there and stop

Interestingly enough, you won't find site_perl mentioned anywhere in a
checkout of git 2.7 itself.  Nor does it appear here:

paul@yow-cube1:~/poky/meta/recipes-devtools/git$ git grep site_perl ./
paul@yow-cube1:~/poky/meta/recipes-devtools/git$ 

I'd reverted the git uprev, no change.  There was a perl uprev that was
recent and I reverted that too as a test but no change.  Unfortunately
I'm not exactly sure when it got broke, so I'd probably just have to
guess and go back a week or two, if I wanted to try and bisect it.

> it.  For what it's worth, I just built git from oe-core master and
> didn't see this problem so it's possible that the breakage is being
> caused by something outside oe-core itself.

Interesting.  I've not got any local bbappends for git so I don't know
what is the trigger.  I'm guessing SVN is perhaps involved, since all
the "extra" files are related to git-svn.  And I'm loosely based on the
self-hosting build appliance here, which IIRC has svn in the pkglist.
So maybe that triggers git to do additional svn import features?

I'm going to locally bbappend do_install to clobber that crap, and in
the meantime if I get a chance to investigate in more detail, I'll
follow up with what I find.  At least we've primed google for the next
guy who runs into this and searches...

P.
--


> 
> p.
> 
>