[PATCH] git: add site_perl to packaged files to fix QA install error

[PATCH] git: add site_perl to packaged files to fix QA install error

[Paul Gortmaker]

Recently this started appearing on my x86_64 builds:

ERROR: QA Issue: git: Files/directories were installed but not shipped in any package:
  /usr/lib64
  /usr/lib64/site_perl
  /usr/lib64/site_perl/5.22.1
  /usr/lib64/site_perl/5.22.1/Git.pm
  /usr/lib64/site_perl/5.22.1/Error.pm
  /usr/lib64/site_perl/5.22.1/perllocal.pod
  /usr/lib64/site_perl/5.22.1/Git
  /usr/lib64/site_perl/5.22.1/auto
  /usr/lib64/site_perl/5.22.1/Git/IndexInfo.pm
  /usr/lib64/site_perl/5.22.1/Git/SVN.pm
  /usr/lib64/site_perl/5.22.1/Git/I18N.pm
  /usr/lib64/site_perl/5.22.1/Git/SVN
  /usr/lib64/site_perl/5.22.1/Git/SVN/Log.pm
  /usr/lib64/site_perl/5.22.1/Git/SVN/Prompt.pm
 [...]
  /usr/lib64/site_perl/5.22.1/Git/SVN/Memoize/YAML.pm
  /usr/lib64/site_perl/5.22.1/auto/Git
  /usr/lib64/site_perl/5.22.1/auto/Git/.packlist
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
git: 24 installed and not shipped files. [installed-vs-shipped]
ERROR: Fatal QA errors found, failing task.
ERROR: Function failed: do_package
ERROR: Logfile of failure stored in: /home/paul/poky/build/tmp/work/core2-64-overc-linux/git/2.7.0-r0/temp/log.do_package.15893
ERROR: Task 11 (/home/paul/poky/meta/recipes-devtools/git/git_2.7.0.bb, do_package) failed with exit code '1'

At first I thought it was the git uprev from 2.5 --> 2.7 but even
after reverting that, the problem remained.  So it must be related
to some other infrastructural or perl change.  As the fix was
relatively obvious, I did not investigate the root cause any
further -- as the perl magic in the git bb is enough to scare
small children.

Cc: Robert Yang <liezhi.yang@windriver.com>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 meta/recipes-devtools/git/git.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/git/git.inc b/meta/recipes-devtools/git/git.inc
index c19e0d47483c..4a0a62888631 100644
--- a/meta/recipes-devtools/git/git.inc
+++ b/meta/recipes-devtools/git/git.inc
@@ -101,6 +101,7 @@ PACKAGES =+ "${PN}-perltools"
 FILES_${PN}-perltools += " \
     ${PERLTOOLS} \
     ${libdir}/perl \
+    ${libdir}/site_perl \
     ${datadir}/perl \
 "
 RDEPENDS_${PN}-perltools = "${PN} perl perl-module-file-path findutils"
-- 
2.1.4

Re: [PATCH] git: add site_perl to packaged files to fix QA install error

[Phil Blundell]

On Sun, 2016-01-31 at 13:27 -0500, Paul Gortmaker wrote:
>  FILES_${PN}-perltools += " \
>      ${PERLTOOLS} \
>      ${libdir}/perl \
> +    ${libdir}/site_perl \
>      ${datadir}/perl \

It seems a bit wrong for git (or any other package) to be installing
itself into site-perl.  That path is meant to be for stuff installed
locally via cpan, right?

So, rather than patching the FILES to accept site-perl I think it would
be better to find out why git is suddenly putting stuff there and stop
it.  For what it's worth, I just built git from oe-core master and
didn't see this problem so it's possible that the breakage is being
caused by something outside oe-core itself.

p.

Re: [PATCH] git: add site_perl to packaged files to fix QA install error

[Paul Gortmaker]

[Re: [OE-core] [PATCH] git: add site_perl to packaged files to fix QA install error] On 31/01/2016 (Sun 21:40) Phil Blundell wrote:

> On Sun, 2016-01-31 at 13:27 -0500, Paul Gortmaker wrote:
> >  FILES_${PN}-perltools += " \
> >      ${PERLTOOLS} \
> >      ${libdir}/perl \
> > +    ${libdir}/site_perl \
> >      ${datadir}/perl \
> 
> It seems a bit wrong for git (or any other package) to be installing
> itself into site-perl.  That path is meant to be for stuff installed
> locally via cpan, right?

I'm not up to speed on perl/cpan specs, but yeah off the cuff it does
seem rather odd for it to be sprawling out into any perl dir IMHO.

Even the perl bb itself seems to actively clobber site_perl for the
non native case.

> 
> So, rather than patching the FILES to accept site-perl I think it would
> be better to find out why git is suddenly putting stuff there and stop

Interestingly enough, you won't find site_perl mentioned anywhere in a
checkout of git 2.7 itself.  Nor does it appear here:

paul@yow-cube1:~/poky/meta/recipes-devtools/git$ git grep site_perl ./
paul@yow-cube1:~/poky/meta/recipes-devtools/git$ 

I'd reverted the git uprev, no change.  There was a perl uprev that was
recent and I reverted that too as a test but no change.  Unfortunately
I'm not exactly sure when it got broke, so I'd probably just have to
guess and go back a week or two, if I wanted to try and bisect it.

> it.  For what it's worth, I just built git from oe-core master and
> didn't see this problem so it's possible that the breakage is being
> caused by something outside oe-core itself.

Interesting.  I've not got any local bbappends for git so I don't know
what is the trigger.  I'm guessing SVN is perhaps involved, since all
the "extra" files are related to git-svn.  And I'm loosely based on the
self-hosting build appliance here, which IIRC has svn in the pkglist.
So maybe that triggers git to do additional svn import features?

I'm going to locally bbappend do_install to clobber that crap, and in
the meantime if I get a chance to investigate in more detail, I'll
follow up with what I find.  At least we've primed google for the next
guy who runs into this and searches...

P.
--


> 
> p.
> 
> 

Re: [PATCH] git: add site_perl to packaged files to fix QA install error

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

On 31 January 2016 at 18:27, Paul Gortmaker <paul.gortmaker@windriver.com>
wrote:

> ERROR: QA Issue: git: Files/directories were installed but not shipped in
> any package:
>   /usr/lib64
>   /usr/lib64/site_perl
>   /usr/lib64/site_perl/5.22.1
>   /usr/lib64/site_perl/5.22.1/Git.pm
>   /usr/lib64/site_perl/5.22.1/Error.pm
>

Interestingly I'm seeing this:

git-perltools:
        /usr/bin/git-cvsserver
        /usr/lib/perl/site_perl/5.22.1/Error.pm
        /usr/lib/perl/site_perl/5.22.1/Git.pm

So my git is installing into site_perl too, but obviously multilib is
breaking something.

Ross

[-- Attachment #2: Type: text/html, Size: 1358 bytes --]